MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.1

MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.1

BUG=664433, 668021
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309
Cr-Commit-Position: refs/heads/master@{#435124}

[dpapad, 2016-11-23 22:01:54]

Description was changed from

==========
MD Settings: roll paper-radio-button, 1. -> 1.3.21

BUG=664433
==========

to

==========
MD Settings: roll paper-radio-button, 1. -> 1.3.21

BUG=664433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-11-23 22:02:24]

Description was changed from

==========
MD Settings: roll paper-radio-button, 1. -> 1.3.21

BUG=664433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.0

BUG=664433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-11-23 22:04:03]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-11-23 22:04:04]

https://codereview.chromium.org/2526053002/diff/1/third_party/polymer/v1_0/co...
File third_party/polymer/v1_0/components_summary.txt (right):

https://codereview.chromium.org/2526053002/diff/1/third_party/polymer/v1_0/co...
third_party/polymer/v1_0/components_summary.txt:290: Repository:
https://github.com/PolymerElements/paper-progress.git
Not sure why those changed from git to https protocol. I used bower version
1.8.0

[dpapad, 2016-11-23 22:05:13]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 22:06:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-23 22:12:30]

lgtm, but wont this break everything?

[dpapad, 2016-11-23 22:14:43]

On 2016/11/23 at 22:12:30, dbeam wrote:
> lgtm, but wont this break everything?

Have not looked at the change closely. Is it a breaking change? I thought not,
let's see what the bots think, but will also do a sanity check manually.

[Dan Beam, 2016-11-23 22:19:42]

On 2016/11/23 22:14:43, dpapad wrote:
> On 2016/11/23 at 22:12:30, dbeam wrote:
> > lgtm, but wont this break everything?
> 
> Have not looked at the change closely. Is it a breaking change? I thought not,
> let's see what the bots think, but will also do a sanity check manually.

visually break ripples for paper-icon-buttons without a size variable set

[scottchen, 2016-11-23 22:43:51]

On 2016/11/23 22:19:42, Dan Beam wrote:
> On 2016/11/23 22:14:43, dpapad wrote:
> > On 2016/11/23 at 22:12:30, dbeam wrote:
> > > lgtm, but wont this break everything?
> > 
> > Have not looked at the change closely. Is it a breaking change? I thought
not,
> > let's see what the bots think, but will also do a sanity check manually.
> 
> visually break ripples for paper-icon-buttons without a size variable set

Did you mean paper-radio-button? If so, there's a default to make it consistent
with the original default size:
https://github.com/PolymerElements/paper-radio-button/commit/77f74b7efdc997af...

[Dan Beam, 2016-11-23 22:46:03]

On 2016/11/23 22:43:51, scottchen wrote:
> On 2016/11/23 22:19:42, Dan Beam wrote:
> > On 2016/11/23 22:14:43, dpapad wrote:
> > > On 2016/11/23 at 22:12:30, dbeam wrote:
> > > > lgtm, but wont this break everything?
> > > 
> > > Have not looked at the change closely. Is it a breaking change? I thought
> not,
> > > let's see what the bots think, but will also do a sanity check manually.
> > 
> > visually break ripples for paper-icon-buttons without a size variable set
> 
> Did you mean paper-radio-button? If so, there's a default to make it
consistent
> with the original default size:
>
https://github.com/PolymerElements/paper-radio-button/commit/77f74b7efdc997af...

yes and yeah, sorry, saw after this comment

still lgtm

[dpapad, 2016-11-24 00:02:45]

https://codereview.chromium.org/2526053002/diff/1/third_party/polymer/v1_0/co...
File
third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js
(right):

https://codereview.chromium.org/2526053002/diff/1/third_party/polymer/v1_0/co...
third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js:40:
if (inkSize === '-1px') {
I did a sanity check, and there is a problem in this line, because inkSize is "
-1px" so the comparison fails, which results in no ripple showing. @scottchen
will follow up with the PR's author to fix this. Holding off this roll until
then.

[commit-bot: I haz the power, 2016-11-24 00:08:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 00:08:48]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[scottchen, 2016-11-24 01:07:12]

On 2016/11/24 00:02:45, dpapad wrote:
>
https://codereview.chromium.org/2526053002/diff/1/third_party/polymer/v1_0/co...
> File
>
third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js
> (right):
> 
>
https://codereview.chromium.org/2526053002/diff/1/third_party/polymer/v1_0/co...
>
third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js:40:
> if (inkSize === '-1px') {
> I did a sanity check, and there is a problem in this line, because inkSize is
"
> -1px" so the comparison fails, which results in no ripple showing. @scottchen
> will follow up with the PR's author to fix this. Holding off this roll until
> then.

Like Demetrios said, after breakpointing here:
https://github.com/PolymerElements/paper-radio-button/blob/master/paper-radio...,
we saw that the value of inkSize is actually '  -1px' (with a space in front of
it). 

We were thinking that maybe we need to do getComputedStyleValue().trim(), and it
looks like according to this commit in polymer core:
https://github.com/Polymer/polymer/commit/5231d87f31f53e23dbde1520c903f6ff86f...,
you were also needing to add .trim() to make the unit test pass.

However, I pulled down the paper-radio-button project and ran `polymer test`,
and as you might've also encountered, the value for inkSize is '-1px' and the
unit test passed.

We're waiting for author of the polymer update to see if he knows why there's a
discrepancy between unit testing the component vs. the behavior we're seeing,
will provide more update when I hear back.

[Dan Beam, 2016-11-29 04:36:49]

can we jump straight to 1.3.1 now that bicknellr@ has fixed?

thanks for the fast PR, noms@ and bicknellr@!

[dpapad, 2016-11-29 18:29:33]

Description was changed from

==========
MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.0

BUG=664433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.1

BUG=664433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-11-29 18:31:35]

@michaelpg: Need OWNERs stamp for third_party/web-animations-js/sources/

@michaelpg, @dbeam: Note the change to PRESUBMIT.py which was added after
previous LG, because of
https://bugs.chromium.org/p/chromium/issues/detail?id=669584.

[dpapad, 2016-11-29 18:31:50]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2016-11-29 18:31:51]

@michaelpg, see previous comment.

[dpapad, 2016-11-29 18:32:32]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 18:32:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-29 19:15:54]

lgtm

[dpapad, 2016-11-29 19:38:54]

Description was changed from

==========
MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.1

BUG=664433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.1

BUG=664433,668021
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-11-29 19:40:03]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2016-11-29 19:40:04]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-11-29 19:40:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 19:52:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 19:52:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[michaelpg, 2016-11-30 00:02:34]

lgtm

https://codereview.chromium.org/2526053002/diff/20001/third_party/polymer/v1_...
File third_party/polymer/v1_0/components_summary.txt (right):

https://codereview.chromium.org/2526053002/diff/20001/third_party/polymer/v1_...
third_party/polymer/v1_0/components_summary.txt:2: Repository:
https://github.com/PolymerElements/app-layout.git
did something change in bower? or is your git config set up to use https instead
of ssh?

[michaelpg, 2016-11-30 00:07:33]

https://codereview.chromium.org/2526053002/diff/1/third_party/polymer/v1_0/co...
File third_party/polymer/v1_0/components_summary.txt (right):

https://codereview.chromium.org/2526053002/diff/1/third_party/polymer/v1_0/co...
third_party/polymer/v1_0/components_summary.txt:290: Repository:
https://github.com/PolymerElements/paper-progress.git
On 2016/11/23 22:04:04, dpapad wrote:
> Not sure why those changed from git to https protocol. I used bower version
> 1.8.0

this URL is grabbed from the .bower.json for each component. did you change
something in your .gitconfig since you last uploaded a change here?

It doesn't really matter, it goes to the same place.

[dpapad, 2016-11-30 00:21:19]

On 2016/11/30 at 00:07:33, michaelpg wrote:
>
https://codereview.chromium.org/2526053002/diff/1/third_party/polymer/v1_0/co...
> File third_party/polymer/v1_0/components_summary.txt (right):
> 
>
https://codereview.chromium.org/2526053002/diff/1/third_party/polymer/v1_0/co...
> third_party/polymer/v1_0/components_summary.txt:290: Repository:
https://github.com/PolymerElements/paper-progress.git
> On 2016/11/23 22:04:04, dpapad wrote:
> > Not sure why those changed from git to https protocol. I used bower version
> > 1.8.0
> 
> this URL is grabbed from the .bower.json for each component. did you change
something in your .gitconfig since you last uploaded a change here?
> 
> It doesn't really matter, it goes to the same place.

I did not change anything in .gitconfig. Perhaps the local NPM/Bower version has
something to do with this (3.10.8 and 1.8.0 respectively).

[dpapad, 2016-11-30 00:28:07]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-11-30 00:29:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 02:04:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480465687130270,
"parent_rev": "f642335cdec081e3fd8291aee9fe68b29e177008", "commit_rev":
"d4a596a2fc3f2292f7efe9fd6cee431f286e8f7b"}

[commit-bot: I haz the power, 2016-11-30 02:05:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 02:08:02]

Description was changed from

==========
MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.1

BUG=664433,668021
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.1

BUG=664433,668021
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309
Cr-Commit-Position: refs/heads/master@{#435124}
==========

[commit-bot: I haz the power, 2016-11-30 02:08:04]

Patchset 2 (id:??) landed as
https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309
Cr-Commit-Position: refs/heads/master@{#435124}