[ios] Implements even more of ChromiumBrowserProvider.

[ios] Implements even more of ChromiumBrowserProvider.

Adds an implementation of GetAppDistributionProvider(), as callers expect that
method to return a non-NULL object.

Adds a call to EnsureBrowserStateKeyedServiceFactoriesBuilt() during startup, as
this method call belongs in Chromium and not in the embedder's provider
implementation.

BUG=666375
Committed: https://crrev.com/84614a2f295cd7f64a192bf02a4a70a09b4ec5e0
Cr-Commit-Position: refs/heads/master@{#434322}

[rohitrao (ping after 24h), 2016-11-23 21:35:27]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 21:36:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2016-11-23 21:36:37]

rohitrao@chromium.org changed reviewers:
+ sdefresne@chromium.org

[commit-bot: I haz the power, 2016-11-23 23:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 23:38:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[rohitrao (ping after 24h), 2016-11-24 00:21:17]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 00:21:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 02:23:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:23:51]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[rohitrao (ping after 24h), 2016-11-24 02:26:17]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:26:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 02:26:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:26:57]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[sdefresne, 2016-11-24 10:56:37]

lgtm

https://codereview.chromium.org/2526043002/diff/1/ios/chrome/browser/provider...
File ios/chrome/browser/providers/chromium_voice_search_provider.mm (right):

https://codereview.chromium.org/2526043002/diff/1/ios/chrome/browser/provider...
ios/chrome/browser/providers/chromium_voice_search_provider.mm:26:
VoiceSearchLanguage* hi =
Why this second language? Does the code need at least two languages? If not, can
we do with just english (maybe en-US and en-GB)?

[rohitrao (ping after 24h), 2016-11-24 11:46:43]

https://codereview.chromium.org/2526043002/diff/1/ios/chrome/browser/provider...
File ios/chrome/browser/providers/chromium_voice_search_provider.mm (right):

https://codereview.chromium.org/2526043002/diff/1/ios/chrome/browser/provider...
ios/chrome/browser/providers/chromium_voice_search_provider.mm:26:
VoiceSearchLanguage* hi =
On 2016/11/24 10:56:37, sdefresne wrote:
> Why this second language? Does the code need at least two languages? If not,
can
> we do with just english (maybe en-US and en-GB)?

No particular reason, it just seemed like having more than one language might
help expose bugs down the road, as the voice search settings page is still
usable (even if changing the pref does nothing).

Choice of languages was arbitrary.  Switched to en+fr.

[rohitrao (ping after 24h), 2016-11-24 11:49:02]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2016-11-24 11:49:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2526043002/#ps20001
(title: "fr")

[commit-bot: I haz the power, 2016-11-24 11:49:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 13:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:50:31]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[rohitrao (ping after 24h), 2016-11-24 13:51:55]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:52:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 14:57:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479995515328640,
"parent_rev": "b3c963239396221f54651692bd605dce22310f47", "commit_rev":
"2c67a36c9a7872289c3b10c08030bf647229e4ac"}

[commit-bot: I haz the power, 2016-11-24 14:58:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-24 15:01:12]

Description was changed from

==========
[ios] Implements even more of ChromiumBrowserProvider.

Adds an implementation of GetAppDistributionProvider(), as callers expect that
method to return a non-NULL object.

Adds a call to EnsureBrowserStateKeyedServiceFactoriesBuilt() during startup, as
this method call belongs in Chromium and not in the embedder's provider
implementation.

BUG=666375
==========

to

==========
[ios] Implements even more of ChromiumBrowserProvider.

Adds an implementation of GetAppDistributionProvider(), as callers expect that
method to return a non-NULL object.

Adds a call to EnsureBrowserStateKeyedServiceFactoriesBuilt() during startup, as
this method call belongs in Chromium and not in the embedder's provider
implementation.

BUG=666375

Committed: https://crrev.com/84614a2f295cd7f64a192bf02a4a70a09b4ec5e0
Cr-Commit-Position: refs/heads/master@{#434322}
==========

[commit-bot: I haz the power, 2016-11-24 15:01:13]

Patchset 2 (id:??) landed as
https://crrev.com/84614a2f295cd7f64a192bf02a4a70a09b4ec5e0
Cr-Commit-Position: refs/heads/master@{#434322}