Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html

Issue 2526013002: [DevTools] Added inline breakpoints (Closed)
Patch Set: rebased test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html
index 526bd949e6424c18f23f6d440690db2476804239..affc2e7e876e5c5783d937e2bbe988cf0c1977c5 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html
@@ -109,10 +109,13 @@ function test()
function testBreakpointsUpdated(next)
{
+ var testSourceFrame;
InspectorTest.showScriptSource("edit-me.js", didShowScriptSource);
function didShowScriptSource(sourceFrame)
{
+ testSourceFrame = sourceFrame;
+ InspectorTest.prepareSourceFrameForBreakpointTest(sourceFrame);
InspectorTest.waitJavaScriptSourceFrameBreakpoints(sourceFrame).then(breakpointAdded);
InspectorTest.setBreakpoint(sourceFrame, 2, "", true);
}
@@ -124,10 +127,10 @@ function test()
function didEditScriptSource()
{
- var breakpoints = panel.visibleView._breakpoints;
- for (var lineNumber in breakpoints)
- InspectorTest.assertEquals("5", lineNumber);
- next();
+ InspectorTest.waitJavaScriptSourceFrameBreakpoints(testSourceFrame)
+ .then(() => InspectorTest.dumpJavaScriptSourceFrameBreakpoints(testSourceFrame))
+ .then(() => Bindings.breakpointManager._allBreakpoints().map(breakpoint => breakpoint.remove()))
+ .then(next);
}
},
@@ -140,6 +143,7 @@ function test()
function didShowScriptSource(sourceFrame)
{
testSourceFrame = sourceFrame;
+ InspectorTest.prepareSourceFrameForBreakpointTest(sourceFrame);
InspectorTest.waitJavaScriptSourceFrameBreakpoints(testSourceFrame).then(breakpointAdded);
InspectorTest.setBreakpoint(sourceFrame, 3, "", true);
}

Powered by Google App Engine
This is Rietveld 408576698