Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: net/spdy/spdy_stream_test_util.h

Issue 2526003002: Disallow multiple HEADERS frames on pushed streams. (Closed)
Patch Set: Rename enum, enum entry, and member. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_stream.cc ('k') | net/spdy/spdy_stream_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream_test_util.h
diff --git a/net/spdy/spdy_stream_test_util.h b/net/spdy/spdy_stream_test_util.h
index ef3617f6944694c481032b03fe84bed146ff1022..0ec2b646d9b334c42ecb9cb4eb5575a9a9591144 100644
--- a/net/spdy/spdy_stream_test_util.h
+++ b/net/spdy/spdy_stream_test_util.h
@@ -27,9 +27,8 @@ class ClosingDelegate : public SpdyStream::Delegate {
~ClosingDelegate() override;
// SpdyStream::Delegate implementation.
- void OnRequestHeadersSent() override;
- SpdyResponseHeadersStatus OnResponseHeadersUpdated(
- const SpdyHeaderBlock& response_headers) override;
+ void OnHeadersSent() override;
+ void OnHeadersReceived(const SpdyHeaderBlock& response_headers) override;
void OnDataReceived(std::unique_ptr<SpdyBuffer> buffer) override;
void OnDataSent() override;
void OnTrailers(const SpdyHeaderBlock& trailers) override;
@@ -49,9 +48,8 @@ class StreamDelegateBase : public SpdyStream::Delegate {
explicit StreamDelegateBase(const base::WeakPtr<SpdyStream>& stream);
~StreamDelegateBase() override;
- void OnRequestHeadersSent() override;
- SpdyResponseHeadersStatus OnResponseHeadersUpdated(
- const SpdyHeaderBlock& response_headers) override;
+ void OnHeadersSent() override;
+ void OnHeadersReceived(const SpdyHeaderBlock& response_headers) override;
void OnDataReceived(std::unique_ptr<SpdyBuffer> buffer) override;
void OnDataSent() override;
void OnTrailers(const SpdyHeaderBlock& trailers) override;
@@ -95,7 +93,7 @@ class StreamDelegateDoNothing : public StreamDelegateBase {
~StreamDelegateDoNothing() override;
};
-// Test delegate that sends data immediately in OnResponseHeadersUpdated().
+// Test delegate that sends data immediately in OnHeadersReceived().
class StreamDelegateSendImmediate : public StreamDelegateBase {
public:
// |data| can be NULL.
@@ -103,8 +101,7 @@ class StreamDelegateSendImmediate : public StreamDelegateBase {
base::StringPiece data);
~StreamDelegateSendImmediate() override;
- SpdyResponseHeadersStatus OnResponseHeadersUpdated(
- const SpdyHeaderBlock& response_headers) override;
+ void OnHeadersReceived(const SpdyHeaderBlock& response_headers) override;
private:
base::StringPiece data_;
@@ -117,21 +114,20 @@ class StreamDelegateWithBody : public StreamDelegateBase {
base::StringPiece data);
~StreamDelegateWithBody() override;
- void OnRequestHeadersSent() override;
+ void OnHeadersSent() override;
private:
scoped_refptr<StringIOBuffer> buf_;
};
-// Test delegate that closes stream in OnResponseHeadersUpdated().
+// Test delegate that closes stream in OnHeadersReceived().
class StreamDelegateCloseOnHeaders : public StreamDelegateBase {
public:
explicit StreamDelegateCloseOnHeaders(
const base::WeakPtr<SpdyStream>& stream);
~StreamDelegateCloseOnHeaders() override;
- SpdyResponseHeadersStatus OnResponseHeadersUpdated(
- const SpdyHeaderBlock& response_headers) override;
+ void OnHeadersReceived(const SpdyHeaderBlock& response_headers) override;
};
} // namespace test
« no previous file with comments | « net/spdy/spdy_stream.cc ('k') | net/spdy/spdy_stream_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698