Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: net/spdy/bidirectional_stream_spdy_impl.cc

Issue 2526003002: Disallow multiple HEADERS frames on pushed streams. (Closed)
Patch Set: Rename enum, enum entry, and member. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/bidirectional_stream_spdy_impl.h ('k') | net/spdy/spdy_http_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/bidirectional_stream_spdy_impl.cc
diff --git a/net/spdy/bidirectional_stream_spdy_impl.cc b/net/spdy/bidirectional_stream_spdy_impl.cc
index 3f755c15a87ba030f614775d6f3326eff48f6359..c705343bdee7e9a2cfe1544d518b1ab67dd69ee8 100644
--- a/net/spdy/bidirectional_stream_spdy_impl.cc
+++ b/net/spdy/bidirectional_stream_spdy_impl.cc
@@ -210,7 +210,7 @@ bool BidirectionalStreamSpdyImpl::GetLoadTimingInfo(
return stream_->GetLoadTimingInfo(load_timing_info);
}
-void BidirectionalStreamSpdyImpl::OnRequestHeadersSent() {
+void BidirectionalStreamSpdyImpl::OnHeadersSent() {
DCHECK(stream_);
negotiated_protocol_ = kProtoHTTP2;
@@ -218,14 +218,12 @@ void BidirectionalStreamSpdyImpl::OnRequestHeadersSent() {
delegate_->OnStreamReady(/*request_headers_sent=*/true);
}
-SpdyResponseHeadersStatus BidirectionalStreamSpdyImpl::OnResponseHeadersUpdated(
+void BidirectionalStreamSpdyImpl::OnHeadersReceived(
const SpdyHeaderBlock& response_headers) {
DCHECK(stream_);
if (delegate_)
delegate_->OnHeadersReceived(response_headers);
-
- return RESPONSE_HEADERS_ARE_COMPLETE;
}
void BidirectionalStreamSpdyImpl::OnDataReceived(
@@ -317,7 +315,7 @@ void BidirectionalStreamSpdyImpl::OnStreamInitialized(int rv) {
stream_->SetDelegate(this);
rv = SendRequestHeadersHelper();
if (rv == OK) {
- OnRequestHeadersSent();
+ OnHeadersSent();
return;
} else if (rv == ERR_IO_PENDING) {
return;
« no previous file with comments | « net/spdy/bidirectional_stream_spdy_impl.h ('k') | net/spdy/spdy_http_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698