Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 25260005: Revert "Refactor PropertyCallbackInfo & FunctionCallbackInfo, part 3." (Closed)

Created:
7 years, 2 months ago by marja
Modified:
7 years, 2 months ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

Revert "Refactor PropertyCallbackInfo & FunctionCallbackInfo, part 3." This reverts commit 977bfe3e9353ead1039878597590ffbd7dd5e725. This might be responsible of the Linux Webkit test failures. BUG= TBR=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -124 lines) Patch
M include/v8.h View 2 chunks +13 lines, -13 lines 0 comments Download
M src/arguments.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/arguments.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 10 chunks +39 lines, -34 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 8 chunks +41 lines, -34 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 9 chunks +35 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marja
Committed patchset #1 manually as r17021 (presubmit successful).
7 years, 2 months ago (2013-09-30 15:34:02 UTC) #1
Jakob Kummerow
7 years, 2 months ago (2013-09-30 17:30:17 UTC) #2
Message was sent while issue was closed.
DBC: next time, please specify the SVN revision number that's being reverted.
Due to the way git-svn works, the git commit hash is unique to your local
checkout.

Powered by Google App Engine
This is Rietveld 408576698