Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 2525973002: Remove the pointer event capturing flag (Closed)

Created:
4 years ago by Navid Zolghadr
Modified:
4 years ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dtapuska+blinkwatch_chromium.org, jam, kinuko+watch, Navid Zolghadr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the pointer event capturing flag This was a flag for testing purposes and was added as part of crbug.com/640700. This CL removes that flag which is no longer needed. BUG=642776 TBR=avi@chromium.org Committed: https://crrev.com/0d9eef755924350100e4ce8d06ea06fac9511a3e Cr-Commit-Position: refs/heads/master@{#434670}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -54 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +2 lines, -4 lines 2 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 4 chunks +7 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (12 generated)
Navid Zolghadr
4 years ago (2016-11-23 16:53:21 UTC) #4
mustaq
lgtm https://codereview.chromium.org/2525973002/diff/1/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/2525973002/diff/1/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode1180 third_party/WebKit/Source/core/input/EventHandler.cpp:1180: m_pointerEventManager->getMouseCapturingNode()) { Nit: fix indentation.
4 years ago (2016-11-23 17:14:08 UTC) #5
Navid Zolghadr
https://codereview.chromium.org/2525973002/diff/1/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/2525973002/diff/1/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode1180 third_party/WebKit/Source/core/input/EventHandler.cpp:1180: m_pointerEventManager->getMouseCapturingNode()) { On 2016/11/23 17:14:08, mustaq wrote: > Nit: ...
4 years ago (2016-11-23 17:24:34 UTC) #6
mustaq
On 2016/11/23 17:24:34, Navid Zolghadr wrote: > https://codereview.chromium.org/2525973002/diff/1/third_party/WebKit/Source/core/input/EventHandler.cpp > File third_party/WebKit/Source/core/input/EventHandler.cpp (right): > > https://codereview.chromium.org/2525973002/diff/1/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode1180 ...
4 years ago (2016-11-23 17:26:10 UTC) #7
Navid Zolghadr
4 years ago (2016-11-23 19:14:52 UTC) #11
Navid Zolghadr
avi@chromium.org: Please review changes in content/*
4 years ago (2016-11-24 15:26:34 UTC) #13
Rick Byers
LGTM Once pointer events hits stable we might hit a few web compat issues where ...
4 years ago (2016-11-25 01:43:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525973002/1
4 years ago (2016-11-28 15:33:47 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 17:05:09 UTC) #20
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0d9eef755924350100e4ce8d06ea06fac9511a3e Cr-Commit-Position: refs/heads/master@{#434670}
4 years ago (2016-11-28 17:07:18 UTC) #22
Avi (use Gerrit)
4 years ago (2016-11-28 18:04:33 UTC) #23
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698