Display content settings for extensions with extension name.

chrome/browser/resources/settings/site_settings/site_list.html

 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action_menu.html">
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
 <link rel="import" href="/i18n_setup.html">
 <link rel="import" href="/icons.html">
 <link rel="import" href="/route.html">
 <link rel="import" href="/settings_shared_css.html">
@@ skipping 48 matching lines @@
 
       <div class="list-frame" hidden$="[[hasSites_(sites)]]">
         <div class="list-item secondary">$i18n{noSitesAdded}</div>
       </div>
       <div class="list-frame menu-content vertical-list" id="listContainer">
         <template is="dom-repeat" items="[[sites]]">
           <div class="list-item">
             <div class="start layout horizontal center" on-tap="onOriginTap_"
                 actionable$="[[enableSiteSettings_]]">
               <div class="favicon-image"
-                  style$="[[computeSiteIcon(item.originForDisplay)]]">
+                  style$="[[computeSiteIcon(item.origin)]]">

[dschuyler, 2016/11/28 21:58:42]

I'm not clear on why this change was made origin rather
than leaving it as originForDisplay or maybe originForFavicon.
Could ya tell me more about this change?

[dullweber, 2016/11/29 09:34:18]

In case of extensions, the originForDisplay is now a text, e.g. "Bookmark
Manager". The favicon function needs a "chrome-extension://asdfghjkl..." url.
Maybe I should rename "originForDisplay" to something like "name" to indicate
that it might not have anything to do with an origin?
I don't need originForFavicon for the site-list because origin already contains
the scheme. Only Zoomlevels need a separate handling for this.

[dschuyler, 2016/11/29 22:46:59]

I like the variable label of |displayName| used elsewhere in this CL.
That could be an optional or separate CL. I.e. I don't want to hold up
this CL for that change, but I think it would be nicer than |origin|
which may not be an origin. 

Maybe the C++ side could set |origin| and
|displayName| separately rather than 
interpreting it on the JS side.

Said another way, I'm suggesting this series of steps:
- that this change back to originForDisplay
- originForDisplay be renamed as displayName
- displayName set on the C++ side to be either an origin intended for display or
an extension name (or something else in the future). [With this CL setting
displayName - does displayName get set in all cases?]
- origin with then only be an origin (or maybe empty if there is not relevant
origin).

WDYT? I'm open to chatting about this outside of this CL if you prefer.

               </div>
               <div class="middle">
                 <div class="selectable">[[item.originForDisplay]]</div>
 
                 <!-- This div must not contain extra whitespace. -->
                 <div class="selectable secondary"
                     >[[computeSiteDescription_(item)]]</div>
               </div>
             </div>
 
@@ skipping 11 matching lines @@
                 </button>
               </div>
             </template>
           </div>
         </template>
       </div>
     </div>
   </template>
   <script src="site_list.js"></script>
 </dom-module>