Handle overlapping uses of MockWebSpeechRecognizer

Handle overlapping uses of MockWebSpeechRecognizer.

More than one speech recognition object may exist at the same time,
all sharing a single MockWebSpeechRecognizer underneath when
running layout tests.

Overlapping uses of speech recognizer objects weren't something
the mock object was designed to gracefully handle, hence fuzzer
inputs would leave the mock object in an invalid state and crash,
when they attempted to do so.

Rather than try to ignore and prevent overlapping uses from going
ahed, we extend MockWebSpeechRecognizer with support for handling
them, queueing recognizer context switching tasks that will run
upon completion of the currently ongoing sequence of tasks that
a speech recognizer object expects.

R=
BUG=668019
Committed: https://crrev.com/879066620c73422866ee6022415e8b436af12a9c
Cr-Commit-Position: refs/heads/master@{#434777}

[sof, 2016-11-23 14:48:46]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 14:49:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2016-11-23 15:42:15]

Description was changed from

==========
Handle overlapping uses of MockWebSpeechSynthesizer.

R=
BUG=
==========

to

==========
Handle overlapping uses of MockWebSpeechSynthesizer.

R=
BUG=668019
==========

[sof, 2016-11-23 15:42:51]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 15:43:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2016-11-23 15:50:54]

sigbjornf@opera.com changed reviewers:
+ dmazzoni@chromium.org

[sof, 2016-11-23 15:50:55]

please take a look.

fuzzer-induced, i don't see a way around removing the "single use" restriction
on this mock object.

[commit-bot: I haz the power, 2016-11-23 16:53:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 16:53:00]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-11-23 22:10:47]

dmazzoni@chromium.org changed reviewers:
+ gshires@chromium.org, hans@chromium.org, tommi@chromium.org

[dmazzoni, 2016-11-23 22:10:48]

The subject should be MockWebSpeechRecognizer, not Synthesizer

I'm happy to rubberstamp the test_runner change, but I'm
not familiar with the speech recognition code well enough -
Tommi, Glen, or Hans, could you take a look?

[sof, 2016-11-24 07:07:45]

Description was changed from

==========
Handle overlapping uses of MockWebSpeechSynthesizer.

R=
BUG=668019
==========

to

==========
Handle overlapping uses of MockWebSpeechRecognizer.

R=
BUG=668019
==========

[sof, 2016-11-24 07:13:00]

On 2016/11/23 22:10:48, dmazzoni wrote:
> The subject should be MockWebSpeechRecognizer, not Synthesizer
> 

oops, thanks.

> I'm happy to rubberstamp the test_runner change, but I'm
> not familiar with the speech recognition code well enough -
> Tommi, Glen, or Hans, could you take a look?

The alternative is to silently return from start() if a recognizer object tries
to use this mock object while another use is in flight. But that felt wrong (to
me.)

[hans, 2016-11-28 16:49:34]

lgtm

This seems fine to me.

Please expand the CL description a little, though.

[dmazzoni, 2016-11-28 16:58:02]

lgtm

https://codereview.chromium.org/2525933002/diff/20001/components/test_runner/...
File components/test_runner/mock_web_speech_recognizer.cc (right):

https://codereview.chromium.org/2525933002/diff/20001/components/test_runner/...
components/test_runner/mock_web_speech_recognizer.cc:140: , handle_(handle)
nit: in Chromium code the comma goes at the end of the previous line, unlike
Blink. Indentation is fine.

https://codereview.chromium.org/2525933002/diff/20001/components/test_runner/...
components/test_runner/mock_web_speech_recognizer.cc:182: handle_ = handle;
nit: should be 2 spaces indent

https://codereview.chromium.org/2525933002/diff/20001/components/test_runner/...
components/test_runner/mock_web_speech_recognizer.cc:183: client_ = client;
Can you DCHECK(client_) or is it okay for it to be nullptr?

[sof, 2016-11-28 21:39:36]

Description was changed from

==========
Handle overlapping uses of MockWebSpeechRecognizer.

R=
BUG=668019
==========

to

==========
Handle overlapping uses of MockWebSpeechRecognizer.

More than one speech recognition object may exist at the same time,
all sharing a single MockWebSpeechRecognizer underneath when
running layout tests.

Overlapping uses of speech recognizer objects weren't something
the mock object was designed to gracefully handle, hence fuzzer
inputs would leave the mock object in an invalid state and crash,
when they attempted to do so.

Rather than try to ignore and prevent overlapping uses from going
ahed, we extend MockWebSpeechRecognizer with support for handling
them, queueing recognizer context switching tasks that will run
upon completion of the currently ongoing sequence of tasks that
a speech recognizer object expects.

R=
BUG=668019
==========

[sof, 2016-11-28 21:39:51]

On 2016/11/28 16:49:34, hans wrote:
> lgtm
> 
> This seems fine to me.
> 
> Please expand the CL description a little, though.

Certainly, done.

[sof, 2016-11-28 21:40:05]

https://codereview.chromium.org/2525933002/diff/20001/components/test_runner/...
File components/test_runner/mock_web_speech_recognizer.cc (right):

https://codereview.chromium.org/2525933002/diff/20001/components/test_runner/...
components/test_runner/mock_web_speech_recognizer.cc:140: , handle_(handle)
On 2016/11/28 16:58:02, dmazzoni wrote:
> nit: in Chromium code the comma goes at the end of the previous line, unlike
> Blink. Indentation is fine.

Fixed, ran git-cl-format (no PRESUBMIT.py in this directory.)

https://codereview.chromium.org/2525933002/diff/20001/components/test_runner/...
components/test_runner/mock_web_speech_recognizer.cc:182: handle_ = handle;
On 2016/11/28 16:58:02, dmazzoni wrote:
> nit: should be 2 spaces indent

Done.

https://codereview.chromium.org/2525933002/diff/20001/components/test_runner/...
components/test_runner/mock_web_speech_recognizer.cc:183: client_ = client;
On 2016/11/28 16:58:02, dmazzoni wrote:
> Can you DCHECK(client_) or is it okay for it to be nullptr?

There's no separate method provided for clearing, so EndedTask will use
SetClientContext(.., nullptr) to clear client_ when it runs. Hence asserting for
!nullptr wouldn't be on.

[sof, 2016-11-28 21:40:09]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2016-11-28 21:40:10]

The patchset sent to the CQ was uploaded after l-g-t-m from hans@chromium.org,
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2525933002/#ps40001
(title: "address style issues")

[commit-bot: I haz the power, 2016-11-28 21:41:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 23:38:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480369209672630,
"parent_rev": "bdb331a430944ebe529ce04d25e49fcb4d004dfe", "commit_rev":
"ec943e5ee02b60a83dba6bb50d5bf307d4332352"}

[commit-bot: I haz the power, 2016-11-28 23:38:54]

Description was changed from

==========
Handle overlapping uses of MockWebSpeechRecognizer.

More than one speech recognition object may exist at the same time,
all sharing a single MockWebSpeechRecognizer underneath when
running layout tests.

Overlapping uses of speech recognizer objects weren't something
the mock object was designed to gracefully handle, hence fuzzer
inputs would leave the mock object in an invalid state and crash,
when they attempted to do so.

Rather than try to ignore and prevent overlapping uses from going
ahed, we extend MockWebSpeechRecognizer with support for handling
them, queueing recognizer context switching tasks that will run
upon completion of the currently ongoing sequence of tasks that
a speech recognizer object expects.

R=
BUG=668019
==========

to

==========
Handle overlapping uses of MockWebSpeechRecognizer.

More than one speech recognition object may exist at the same time,
all sharing a single MockWebSpeechRecognizer underneath when
running layout tests.

Overlapping uses of speech recognizer objects weren't something
the mock object was designed to gracefully handle, hence fuzzer
inputs would leave the mock object in an invalid state and crash,
when they attempted to do so.

Rather than try to ignore and prevent overlapping uses from going
ahed, we extend MockWebSpeechRecognizer with support for handling
them, queueing recognizer context switching tasks that will run
upon completion of the currently ongoing sequence of tasks that
a speech recognizer object expects.

R=
BUG=668019
==========

[commit-bot: I haz the power, 2016-11-28 23:38:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-28 23:40:50]

Description was changed from

==========
Handle overlapping uses of MockWebSpeechRecognizer.

More than one speech recognition object may exist at the same time,
all sharing a single MockWebSpeechRecognizer underneath when
running layout tests.

Overlapping uses of speech recognizer objects weren't something
the mock object was designed to gracefully handle, hence fuzzer
inputs would leave the mock object in an invalid state and crash,
when they attempted to do so.

Rather than try to ignore and prevent overlapping uses from going
ahed, we extend MockWebSpeechRecognizer with support for handling
them, queueing recognizer context switching tasks that will run
upon completion of the currently ongoing sequence of tasks that
a speech recognizer object expects.

R=
BUG=668019
==========

to

==========
Handle overlapping uses of MockWebSpeechRecognizer.

More than one speech recognition object may exist at the same time,
all sharing a single MockWebSpeechRecognizer underneath when
running layout tests.

Overlapping uses of speech recognizer objects weren't something
the mock object was designed to gracefully handle, hence fuzzer
inputs would leave the mock object in an invalid state and crash,
when they attempted to do so.

Rather than try to ignore and prevent overlapping uses from going
ahed, we extend MockWebSpeechRecognizer with support for handling
them, queueing recognizer context switching tasks that will run
upon completion of the currently ongoing sequence of tasks that
a speech recognizer object expects.

R=
BUG=668019

Committed: https://crrev.com/879066620c73422866ee6022415e8b436af12a9c
Cr-Commit-Position: refs/heads/master@{#434777}
==========

[commit-bot: I haz the power, 2016-11-28 23:40:51]

Patchset 3 (id:??) landed as
https://crrev.com/879066620c73422866ee6022415e8b436af12a9c
Cr-Commit-Position: refs/heads/master@{#434777}