chrome/browser/extensions/crx_installer.cc - Issue 252593003: Improve UI for unpacked extensions failing to load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 252593003: Improve UI for unpacked extensions failing to load (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ExtensionCode js object Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/crx_installer.cc

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc

index 57d2a3692c9e1146f5eb17aae619267bfde42df5..ead5aa816bab91b37821a47bd774d1a6b933a2d3 100644

--- a/chrome/browser/extensions/crx_installer.cc

+++ b/chrome/browser/extensions/crx_installer.cc

@@ -755,8 +755,7 @@ void CrxInstaller::ReportFailureFromUIThread(const CrxInstallerError& error) {

// rid of this line.

ExtensionErrorReporter::GetInstance()->ReportError(

error.message(),

- false, // Be quiet.

- NULL); // Caller expects no response.

+ false); // Be quiet.

if (client_)

client_->OnInstallFailure(error);