Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: chrome/browser/extensions/extension_error_reporter.cc

Issue 252593003: Improve UI for unpacked extensions failing to load (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Android fix Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_error_reporter.h ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_error_reporter.cc
diff --git a/chrome/browser/extensions/extension_error_reporter.cc b/chrome/browser/extensions/extension_error_reporter.cc
index 0b729caf53d37580cd33eaa4c39a9b5d67311085..fbcc5b1df9adb3cfa0d5de263ca3591d5e43daa5 100644
--- a/chrome/browser/extensions/extension_error_reporter.cc
+++ b/chrome/browser/extensions/extension_error_reporter.cc
@@ -36,8 +36,7 @@ ExtensionErrorReporter::ExtensionErrorReporter(bool enable_noisy_errors)
ExtensionErrorReporter::~ExtensionErrorReporter() {}
void ExtensionErrorReporter::ReportError(const base::string16& message,
- bool be_noisy,
- bool* user_response) {
+ bool be_noisy) {
// NOTE: There won't be a ui_loop_ in the unit test environment.
if (ui_loop_) {
CHECK(base::MessageLoop::current() == ui_loop_)
@@ -51,19 +50,10 @@ void ExtensionErrorReporter::ReportError(const base::string16& message,
LOG(WARNING) << "Extension error: " << message;
if (enable_noisy_errors_ && be_noisy) {
- if (user_response) {
- *user_response =
- chrome::MESSAGE_BOX_RESULT_YES ==
- chrome::ShowMessageBox(NULL,
- base::ASCIIToUTF16("Extension error"),
- message,
- chrome::MESSAGE_BOX_TYPE_QUESTION);
- } else {
- chrome::ShowMessageBox(NULL,
- base::ASCIIToUTF16("Extension error"),
- message,
- chrome::MESSAGE_BOX_TYPE_WARNING);
- }
+ chrome::ShowMessageBox(NULL,
+ base::ASCIIToUTF16("Extension error"),
+ message,
+ chrome::MESSAGE_BOX_TYPE_WARNING);
}
}
« no previous file with comments | « chrome/browser/extensions/extension_error_reporter.h ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698