Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.h

Issue 252593003: Improve UI for unpacked extensions failing to load (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.h
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.h b/chrome/browser/ui/webui/extensions/extension_settings_handler.h
index a4709b06041a282d61ddda2f6a871f592e81c819..5347fc77f03c8f791e0d4c5582b679c88f5501f6 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.h
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.h
@@ -25,7 +25,6 @@
#include "content/public/browser/web_ui_message_handler.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_prefs_observer.h"
-#include "ui/shell_dialogs/select_file_dialog.h"
#include "url/gurl.h"
class ExtensionService;
@@ -68,7 +67,6 @@ class ExtensionSettingsHandler
: public content::WebUIMessageHandler,
public content::NotificationObserver,
public content::WebContentsObserver,
- public ui::SelectFileDialog::Listener,
public ErrorConsole::Observer,
public ExtensionInstallPrompt::Delegate,
public ExtensionPrefsObserver,
@@ -109,29 +107,6 @@ class ExtensionSettingsHandler
// WebUIMessageHandler implementation.
virtual void RegisterMessages() OVERRIDE;
- // Loads an unpacked extension from |path|.
- void LoadUnpackedExtension(const base::FilePath& path);
-
- // Returns the index of the given FilePath in the vector of currently loading
- // extensions. Returns -1 if not found.
- int IndexOfLoadingPath(const base::FilePath& path);
-
- // Adds |path| to the vector of currently loading extensions. Registers
- // for the load retry notification if vector is empty before call.
- void AddLoadingPath(const base::FilePath& path);
-
- // Removes |path| from the vector of currently loading extensions. Unregisters
- // for the load retry notification if vector is empty after call.
- void RemoveLoadingPath(const base::FilePath& path);
-
- // SelectFileDialog::Listener implementation.
- virtual void FileSelected(const base::FilePath& path,
- int index,
- void* params) OVERRIDE;
- virtual void MultiFilesSelected(
- const std::vector<base::FilePath>& files, void* params) OVERRIDE;
- virtual void FileSelectionCanceled(void* params) OVERRIDE;
-
// ErrorConsole::Observer implementation.
virtual void OnErrorAdded(const ExtensionError* error) OVERRIDE;
@@ -201,9 +176,6 @@ class ExtensionSettingsHandler
// Callback for "autoupdate" message.
void HandleAutoUpdateMessage(const base::ListValue* args);
- // Callback for "loadUnpackedExtension" message.
- void HandleLoadUnpackedExtensionMessage(const base::ListValue* args);
-
// Callback for the "dismissADTPromo" message.
void HandleDismissADTPromoMessage(const base::ListValue* args);
@@ -254,17 +226,6 @@ class ExtensionSettingsHandler
// A convenience member, filled once the extension_service_ is known.
ManagementPolicy* management_policy_;
- // Used to pick the directory when loading an extension.
- scoped_refptr<ui::SelectFileDialog> load_extension_dialog_;
-
- // Used to start the |load_extension_dialog_| in the last directory that was
- // loaded.
- base::FilePath last_unpacked_directory_;
-
- // Used to keep track of FilePaths for all extensions in the process of
- // loading for the purpose of retrying on load failure.
- std::vector<base::FilePath> loading_extension_directories_;
-
// Used to show confirmation UI for uninstalling extensions in incognito mode.
scoped_ptr<ExtensionUninstallDialog> extension_uninstall_dialog_;

Powered by Google App Engine
This is Rietveld 408576698