chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 252593003: Improve UI for unpacked extensions failing to load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 252593003: Improve UI for unpacked extensions failing to load (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_notification_types.h ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | chrome/browser/extensions/unpacked_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index dec20db3a9d58d6c5926512ce98901009f3181d0..cfc1077fb4caa55b2b0ded2e94627f1ae5b2fc5e 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -843,8 +843,7 @@ void DeveloperPrivateEnableFunction::OnRequirementsChecked(

} else {

ExtensionErrorReporter::GetInstance()->ReportError(

base::UTF8ToUTF16(JoinString(requirements_errors, ' ')),

- true, // Be noisy.

- NULL); // Caller expects no response.

+ true); // Be noisy.

}

Release();

}