Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: chrome/browser/extensions/extension_service.h

Issue 252593003: Improve UI for unpacked extensions failing to load (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Android fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 341
342 // Note that this may return NULL if autoupdate is not turned on. 342 // Note that this may return NULL if autoupdate is not turned on.
343 extensions::ExtensionUpdater* updater(); 343 extensions::ExtensionUpdater* updater();
344 344
345 // Notify the frontend that there was an error loading an extension. 345 // Notify the frontend that there was an error loading an extension.
346 // This method is public because UnpackedInstaller and InstalledLoader 346 // This method is public because UnpackedInstaller and InstalledLoader
347 // can post to here. 347 // can post to here.
348 // TODO(aa): Remove this. It doesn't do enough to be worth the dependency 348 // TODO(aa): Remove this. It doesn't do enough to be worth the dependency
349 // of these classes on ExtensionService. 349 // of these classes on ExtensionService.
350 void ReportExtensionLoadError(const base::FilePath& extension_path, 350 void ReportExtensionLoadError(const base::FilePath& extension_path,
351 const std::string& error, 351 const std::string& error);
352 bool be_noisy);
353
354 // Notifies ExtensionSettingsHandler whether or not to retry installation for
355 // given |extension_path|.
356 void NotifyLoadRetry(bool retry, const base::FilePath& extension_path);
357 352
358 // ExtensionHost of background page calls this method right after its render 353 // ExtensionHost of background page calls this method right after its render
359 // view has been created. 354 // view has been created.
360 void DidCreateRenderViewForBackgroundPage(extensions::ExtensionHost* host); 355 void DidCreateRenderViewForBackgroundPage(extensions::ExtensionHost* host);
361 356
362 // For the extension in |version_path| with |id|, check to see if it's an 357 // For the extension in |version_path| with |id|, check to see if it's an
363 // externally managed extension. If so, uninstall it. 358 // externally managed extension. If so, uninstall it.
364 void CheckExternalUninstall(const std::string& id); 359 void CheckExternalUninstall(const std::string& id);
365 360
366 // Changes sequenced task runner for crx installation tasks to |task_runner|. 361 // Changes sequenced task runner for crx installation tasks to |task_runner|.
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 707 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
713 GreylistedExtensionDisabled); 708 GreylistedExtensionDisabled);
714 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 709 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
715 GreylistDontEnableManuallyDisabled); 710 GreylistDontEnableManuallyDisabled);
716 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 711 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
717 GreylistUnknownDontChange); 712 GreylistUnknownDontChange);
718 DISALLOW_COPY_AND_ASSIGN(ExtensionService); 713 DISALLOW_COPY_AND_ASSIGN(ExtensionService);
719 }; 714 };
720 715
721 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 716 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_error_reporter.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698