Improve UI for unpacked extensions failing to load

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <set>
 
@@ skipping 2048 matching lines @@
   // notification on installation. For such extensions, mark them acknowledged
   // now to suppress the notification.
   if (mark_acknowledged)
     AcknowledgeExternalExtension(id);
 
   return true;
 }
 
 void ExtensionService::ReportExtensionLoadError(
     const base::FilePath& extension_path,
-    const std::string &error,
-    bool be_noisy) {
+    const std::string &error) {
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_LOAD_ERROR,
       content::Source<Profile>(profile_),
       content::Details<const std::string>(&error));
 
   std::string path_str = base::UTF16ToUTF8(extension_path.LossyDisplayName());
-  bool retry = false;
-  std::string retry_prompt;
-  if (be_noisy)
-    retry_prompt = "\n\nWould you like to retry?";
-
   base::string16 message = base::UTF8ToUTF16(
-      base::StringPrintf("Could not load extension from '%s'. %s%s",
+      base::StringPrintf("Could not load extension from '%s'. %s",
                          path_str.c_str(),
-                         error.c_str(),
-                         retry_prompt.c_str()));
-  ExtensionErrorReporter::GetInstance()->ReportError(message, be_noisy, &retry);
-  NotifyLoadRetry(retry, extension_path);
-}
-
-void ExtensionService::NotifyLoadRetry(bool retry,
-                                       const base::FilePath& extension_path) {
-  std::pair<bool, const base::FilePath&> details(retry, extension_path);
-  content::NotificationService::current()->Notify(
-      chrome::NOTIFICATION_EXTENSION_LOAD_RETRY,
-      content::Source<Profile>(profile_),
-      content::Details<std::pair<bool, const base::FilePath&> >(&details));
+                         error.c_str()));
+  ExtensionErrorReporter::GetInstance()->ReportError(message, false);
 }
 
 void ExtensionService::DidCreateRenderViewForBackgroundPage(
     extensions::ExtensionHost* host) {
   OrphanedDevTools::iterator iter =
       orphaned_dev_tools_.find(host->extension_id());
   if (iter == orphaned_dev_tools_.end())
     return;
 
   iter->second->ConnectRenderViewHost(host->render_view_host());
@@ skipping 335 matching lines @@
 void ExtensionService::UnloadAllExtensionsInternal() {
   profile_->GetExtensionSpecialStoragePolicy()->RevokeRightsForAllExtensions();
 
   registry_->ClearAll();
   system_->runtime_data()->ClearAll();
 
   // TODO(erikkay) should there be a notification for this?  We can't use
   // EXTENSION_UNLOADED since that implies that the extension has been disabled
   // or uninstalled.
 }