Change the Data Saver infobar promo icon to blue

build/android/lint/suppressions.xml

Index: build/android/lint/suppressions.xml
diff --git a/build/android/lint/suppressions.xml b/build/android/lint/suppressions.xml
index 91765f36d21cfd1a372601a836a27e96cac842ea..dea2b63841c0b5276bbaed6f1ef2b0ac00f5dd6d 100644
--- a/build/android/lint/suppressions.xml
+++ b/build/android/lint/suppressions.xml
@@ -335,7 +335,7 @@ Still reading?
     <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_microphone.png"/>
     <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_midi.png"/>
     <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_multiple_downloads.png"/>
-    <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_previews.png"/>
+    <ignore regexp="chrome/android/java/res/drawable-hdpi/data_reduction_icon.png"/>

[gone, 2016/11/22 23:57:38]

Put this in the proper place alphabetically.  If this icon is only being used
for infobars it should be prefixed with infobar_ though.  Makes it easier to
track.

[megjablon, 2016/11/23 00:06:20]

It is currently only being used for infobars, but could be used elsewhere in
Data Saver UI, which is why I didn't prefix it with infobar. When I was
searching for where we already had this icon in the code it was harder to find
under infobar_previews so I thought the more general name would make it easier
to find in the future if someone is looking for the blue Data Saver icon. If you
strongly prefer that prefix, I can add it and then remove it when we decide to
use it elsewhere.

[gone, 2016/11/23 00:32:00]

infobar_previews didn't make much sense as a name, but data_reduction_icon
doesn't make sense as a name for an image representing the chromium icon,
either.  If anything, it should be called infobar_chromium.png, mainly because:

1) infobar_*png icon assets are all blue:
https://alpha-1-dot-chrome-assets.googleplex.com/#search=infobar_|order=0|pla...

2) If this infobar-specific icon is used somewhere else, you run the risk of
accidentally replacing it and messing up the infobar styling.

WDYT?

[gone, 2016/11/23 00:34:07]

Welp, I was outvoted in a cubicle discussion.  They suggested calling it
"infobar_chrome.png" instead.

[megjablon, 2016/11/23 00:44:32]

Ok this makes sense to me. Renamed.

     <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_protected_media_identifier.png"/>
     <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_restore.png"/>
     <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_screen_share.png"/>