Change the Data Saver infobar promo icon to blue

Change the Data Saver infobar promo icon to blue

All of Data Saver's UI should use the blue icon. The infobar promo needs
to use the existing blue icon rather than the app_icon.

BUG=660356
Committed: https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6
Cr-Commit-Position: refs/heads/master@{#434104}

[megjablon, 2016-11-22 23:53:52]

megjablon@chromium.org changed reviewers:
+ brucedawson@chromium.org, dfalcantara@chromium.org

[megjablon, 2016-11-22 23:53:52]

brucedawson: suppressions.xml
dfalcantara: everything else

[gone, 2016-11-22 23:57:38]

https://codereview.chromium.org/2525843002/diff/1/build/android/lint/suppress...
File build/android/lint/suppressions.xml (right):

https://codereview.chromium.org/2525843002/diff/1/build/android/lint/suppress...
build/android/lint/suppressions.xml:338: <ignore
regexp="chrome/android/java/res/drawable-hdpi/data_reduction_icon.png"/>
Put this in the proper place alphabetically.  If this icon is only being used
for infobars it should be prefixed with infobar_ though.  Makes it easier to
track.

[megjablon, 2016-11-23 00:06:20]

https://codereview.chromium.org/2525843002/diff/1/build/android/lint/suppress...
File build/android/lint/suppressions.xml (right):

https://codereview.chromium.org/2525843002/diff/1/build/android/lint/suppress...
build/android/lint/suppressions.xml:338: <ignore
regexp="chrome/android/java/res/drawable-hdpi/data_reduction_icon.png"/>
On 2016/11/22 23:57:38, dfalcantara (check my queue) wrote:
> Put this in the proper place alphabetically.  If this icon is only being used
> for infobars it should be prefixed with infobar_ though.  Makes it easier to
> track.

It is currently only being used for infobars, but could be used elsewhere in
Data Saver UI, which is why I didn't prefix it with infobar. When I was
searching for where we already had this icon in the code it was harder to find
under infobar_previews so I thought the more general name would make it easier
to find in the future if someone is looking for the blue Data Saver icon. If you
strongly prefer that prefix, I can add it and then remove it when we decide to
use it elsewhere.

[megjablon, 2016-11-23 00:07:01]

Patchset #2 (id:20001) has been deleted

[gone, 2016-11-23 00:32:00]

https://codereview.chromium.org/2525843002/diff/1/build/android/lint/suppress...
File build/android/lint/suppressions.xml (right):

https://codereview.chromium.org/2525843002/diff/1/build/android/lint/suppress...
build/android/lint/suppressions.xml:338: <ignore
regexp="chrome/android/java/res/drawable-hdpi/data_reduction_icon.png"/>
On 2016/11/23 00:06:20, megjablon wrote:
> On 2016/11/22 23:57:38, dfalcantara (check my queue) wrote:
> > Put this in the proper place alphabetically.  If this icon is only being
used
> > for infobars it should be prefixed with infobar_ though.  Makes it easier to
> > track.
> 
> It is currently only being used for infobars, but could be used elsewhere in
> Data Saver UI, which is why I didn't prefix it with infobar. When I was
> searching for where we already had this icon in the code it was harder to find
> under infobar_previews so I thought the more general name would make it easier
> to find in the future if someone is looking for the blue Data Saver icon. If
you
> strongly prefer that prefix, I can add it and then remove it when we decide to
> use it elsewhere.

infobar_previews didn't make much sense as a name, but data_reduction_icon
doesn't make sense as a name for an image representing the chromium icon,
either.  If anything, it should be called infobar_chromium.png, mainly because:

1) infobar_*png icon assets are all blue:
https://alpha-1-dot-chrome-assets.googleplex.com/#search=infobar_|order=0|pla...

2) If this infobar-specific icon is used somewhere else, you run the risk of
accidentally replacing it and messing up the infobar styling.

WDYT?

[gone, 2016-11-23 00:34:08]

https://codereview.chromium.org/2525843002/diff/1/build/android/lint/suppress...
File build/android/lint/suppressions.xml (right):

https://codereview.chromium.org/2525843002/diff/1/build/android/lint/suppress...
build/android/lint/suppressions.xml:338: <ignore
regexp="chrome/android/java/res/drawable-hdpi/data_reduction_icon.png"/>
On 2016/11/23 00:32:00, dfalcantara (check my queue) wrote:
> On 2016/11/23 00:06:20, megjablon wrote:
> > On 2016/11/22 23:57:38, dfalcantara (check my queue) wrote:
> > > Put this in the proper place alphabetically.  If this icon is only being
> used
> > > for infobars it should be prefixed with infobar_ though.  Makes it easier
to
> > > track.
> > 
> > It is currently only being used for infobars, but could be used elsewhere in
> > Data Saver UI, which is why I didn't prefix it with infobar. When I was
> > searching for where we already had this icon in the code it was harder to
find
> > under infobar_previews so I thought the more general name would make it
easier
> > to find in the future if someone is looking for the blue Data Saver icon. If
> you
> > strongly prefer that prefix, I can add it and then remove it when we decide
to
> > use it elsewhere.
> 
> infobar_previews didn't make much sense as a name, but data_reduction_icon
> doesn't make sense as a name for an image representing the chromium icon,
> either.  If anything, it should be called infobar_chromium.png, mainly
because:
> 
> 1) infobar_*png icon assets are all blue:
>
https://alpha-1-dot-chrome-assets.googleplex.com/#search=infobar_%7Corder=0%7...
> 
> 2) If this infobar-specific icon is used somewhere else, you run the risk of
> accidentally replacing it and messing up the infobar styling.
> 
> WDYT?

Welp, I was outvoted in a cubicle discussion.  They suggested calling it
"infobar_chrome.png" instead.

[megjablon, 2016-11-23 00:43:40]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 00:44:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2016-11-23 00:44:32]

https://codereview.chromium.org/2525843002/diff/1/build/android/lint/suppress...
File build/android/lint/suppressions.xml (right):

https://codereview.chromium.org/2525843002/diff/1/build/android/lint/suppress...
build/android/lint/suppressions.xml:338: <ignore
regexp="chrome/android/java/res/drawable-hdpi/data_reduction_icon.png"/>
On 2016/11/23 00:34:07, dfalcantara (check my queue) wrote:
> On 2016/11/23 00:32:00, dfalcantara (check my queue) wrote:
> > On 2016/11/23 00:06:20, megjablon wrote:
> > > On 2016/11/22 23:57:38, dfalcantara (check my queue) wrote:
> > > > Put this in the proper place alphabetically.  If this icon is only being
> > used
> > > > for infobars it should be prefixed with infobar_ though.  Makes it
easier
> to
> > > > track.
> > > 
> > > It is currently only being used for infobars, but could be used elsewhere
in
> > > Data Saver UI, which is why I didn't prefix it with infobar. When I was
> > > searching for where we already had this icon in the code it was harder to
> find
> > > under infobar_previews so I thought the more general name would make it
> easier
> > > to find in the future if someone is looking for the blue Data Saver icon.
If
> > you
> > > strongly prefer that prefix, I can add it and then remove it when we
decide
> to
> > > use it elsewhere.
> > 
> > infobar_previews didn't make much sense as a name, but data_reduction_icon
> > doesn't make sense as a name for an image representing the chromium icon,
> > either.  If anything, it should be called infobar_chromium.png, mainly
> because:
> > 
> > 1) infobar_*png icon assets are all blue:
> >
>
https://alpha-1-dot-chrome-assets.googleplex.com/#search=infobar_%7Corder=0%7...
> > 
> > 2) If this infobar-specific icon is used somewhere else, you run the risk of
> > accidentally replacing it and messing up the infobar styling.
> > 
> > WDYT?
> 
> Welp, I was outvoted in a cubicle discussion.  They suggested calling it
> "infobar_chrome.png" instead.

Ok this makes sense to me. Renamed.

[gone, 2016-11-23 01:01:42]

lgtm

[commit-bot: I haz the power, 2016-11-23 01:26:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:26:29]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-11-23 01:31:46]

lgtm

[megjablon, 2016-11-23 03:28:03]

The CQ bit was checked by megjablon@chromium.org

[commit-bot: I haz the power, 2016-11-23 03:28:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 03:32:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479871683823500,
"parent_rev": "32640500311ae0d4b15fdd047f5b20658c432e53", "commit_rev":
"fe8017ac208d8109b3aacfd58df0bd134865db8c"}

[commit-bot: I haz the power, 2016-11-23 03:33:11]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-23 03:35:05]

Description was changed from

==========
Change the Data Saver infobar promo icon to blue

All of Data Saver's UI should use the blue icon. The infobar promo needs
to use the existing blue icon rather than the app_icon.

BUG=660356
==========

to

==========
Change the Data Saver infobar promo icon to blue

All of Data Saver's UI should use the blue icon. The infobar promo needs
to use the existing blue icon rather than the app_icon.

BUG=660356

Committed: https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6
Cr-Commit-Position: refs/heads/master@{#434104}
==========

[commit-bot: I haz the power, 2016-11-23 03:35:07]

Patchset 3 (id:??) landed as
https://crrev.com/cbd68308efc017962dc15fa9fa6dc8a30bd885f6
Cr-Commit-Position: refs/heads/master@{#434104}