Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1867)

Unified Diff: base/files/file_proxy.h

Issue 252583007: Replace FileUtilProxy with FileProxy in renderer_host/pepper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/files/file_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file_proxy.h
diff --git a/base/files/file_proxy.h b/base/files/file_proxy.h
index 3c834f673eac90570c6be71095768ca8f90fdebf..f990d044d376137ac1200daff75f42c65b2cd51c 100644
--- a/base/files/file_proxy.h
+++ b/base/files/file_proxy.h
@@ -33,12 +33,9 @@ class Time;
// In other words, having a sequence like
//
// proxy.Write(...);
-// delete proxy;
+// proxy.Write(...);
//
-// will keep the file valid during the Write operation but will cause the file
-// to be closed in the current thread, when the operation finishes. If Close is
-// called right away after Write, the second call will fail because there is an
-// operation in progress.
+// means the second Write will always fail.
class BASE_EXPORT FileProxy : public SupportsWeakPtr<FileProxy> {
public:
// This callback is used by methods that report only an error code. It is
@@ -88,8 +85,14 @@ class BASE_EXPORT FileProxy : public SupportsWeakPtr<FileProxy> {
// length to simulate a new file), and false otherwise.
bool created() const { return file_.created(); }
+ // Claims ownership of |file|. It is an error to call this method when
+ // IsValid() returns true.
+ void SetFile(File file);
+
File TakeFile();
+ PlatformFile GetPlatformFile() const;
+
// Proxies File::Close. The callback can be null.
// This returns false if task posting to |task_runner| has failed.
bool Close(const StatusCallback& callback);
@@ -127,7 +130,6 @@ class BASE_EXPORT FileProxy : public SupportsWeakPtr<FileProxy> {
private:
friend class FileHelper;
- void SetFile(File file);
TaskRunner* task_runner() { return task_runner_.get(); }
scoped_refptr<TaskRunner> task_runner_;
« no previous file with comments | « no previous file | base/files/file_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698