Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: gm/rebaseline_server/base_unittest.py

Issue 252583005: rebaseline_server unittests: output tkdiff lines when actuals don't match expectations (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/base_unittest.py
diff --git a/gm/rebaseline_server/base_unittest.py b/gm/rebaseline_server/base_unittest.py
index 172a8c0ed913853f63157f6bf59ae77e8008e61f..eec0c8da0a4e836a97392482e2054baf02ad59c1 100755
--- a/gm/rebaseline_server/base_unittest.py
+++ b/gm/rebaseline_server/base_unittest.py
@@ -49,8 +49,11 @@ class TestCase(unittest.TestCase):
# Ravi notes: if somebody later comes along and adds cleanup code below
# this assert, then if tests fail, the artifacts will not be cleaned up.
assert (not different_files), \
- ('found differing files between actual dir %s and expected dir %s: %s' %
- (self._output_dir_actual, self._output_dir_expected, different_files))
+ ('found differing files:\n' +
+ '\n'.join(['tkdiff %s %s &' % (
+ os.path.join(self._output_dir_actual, basename),
+ os.path.join(self._output_dir_expected, basename))
+ for basename in different_files]))
def shortDescription(self):
"""Tell unittest framework to not print docstrings for test cases."""
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698