Issue 252583004: Don't adopt the AST id from previous if id is none, since previous may have mismatching expected st…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252583004: Don't adopt the AST id from previous if id is none, since previous may have mismatching expected st… (Closed)

Created:
6 years, 8 months ago by Toon Verwaest

Modified:
6 years, 8 months ago

Reviewers:
Jarin, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't adopt the AST id from previous if id is none, since previous may have mismatching expected stack height. Additionally, harden merging of simulates after instructions with side effects and ensure there's a simulate before HEnterInlined. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20967

Patch Set 1 #

Patch Set 2 : Remove id merging #

Patch Set 3 : Ensure we advance while consuming simulates #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -18 lines)			Patch
M	src/hydrogen-instructions.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/hydrogen-removable-simulates.cc	View	1 2	2 chunks	+27 lines, -13 lines	0 comments	Download
A +	test/mjsunit/regress/regress-lazy-deopt-inlining2.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

6 years, 8 months ago (2014-04-25 09:52:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r20967 (presubmit successful).

Expand Messages | Collapse Messages