third_party/hwcplus/include/cutils/properties.h - Issue 252583002: Make it possible to build libhardware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/hwcplus/include/cutils/properties.h

Issue 252583002: Make it possible to build libhardware. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hwc2

Patch Set: clean up more lint Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/hwcplus/include/cutils/properties.h

diff --git a/third_party/hwcplus/include/cutils/properties.h b/third_party/hwcplus/include/cutils/properties.h

index 2c70165b054cf7267339891a8e31bbc6c59591ba..97fd343de9806b57229ed3807936893f5cc20eda 100644

--- a/third_party/hwcplus/include/cutils/properties.h

+++ b/third_party/hwcplus/include/cutils/properties.h

@@ -19,7 +19,6 @@

#include <sys/cdefs.h>

#include <stddef.h>

-#include <sys/system_properties.h>

rjkroege 2014/04/25 21:28:07 could you introduce a #define to leave this also c

#ifdef __cplusplus

extern "C" {

@@ -32,8 +31,8 @@ extern "C" {

** WARNING: system/bionic/include/sys/system_properties.h also defines

** these, but with different names. (TODO: fix that)

-#define PROPERTY_KEY_MAX PROP_NAME_MAX

-#define PROPERTY_VALUE_MAX PROP_VALUE_MAX

+#define PROPERTY_KEY_MAX 32

+#define PROPERTY_VALUE_MAX 92

/* property_get: returns the length of the value which will never be

** greater than PROPERTY_VALUE_MAX - 1 and will always be zero terminated.