Make it possible to build libhardware.

Re-land: Make it possible to build libhardware.
    
Fix up some include files, supply some functions, and make the hardware
module search path configurable at compile time and run time.

TBR=dalecurtis@chromium.org
BUG=358029
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268211

[fjhenigman, 2014-04-24 21:08:40]

As explained in https://codereview.chromium.org/254683002/ this code is
currently only built by a chrome so ebuild.

[fjhenigman, 2014-04-25 01:50:04]

As explained in https://codereview.chromium.org/254683002/ this code is
currently only built by a chrome os ebuild:
https://chromium-review.googlesource.com/#/c/194812/

[rjkroege, 2014-04-25 21:28:07]

https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/incl...
File third_party/hwcplus/include/cutils/properties.h (left):

https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/incl...
third_party/hwcplus/include/cutils/properties.h:22: #include
<sys/system_properties.h>
could you introduce a #define to leave this also compilable on android?

https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/incl...
File third_party/hwcplus/include/system/graphics.h (right):

https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/incl...
third_party/hwcplus/include/system/graphics.h:20: #include <stddef.h>
same comment: add #ifdef?

https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/src/...
File third_party/hwcplus/src/hardware.c (right):

https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/src/...
third_party/hwcplus/src/hardware.c:129: char *base = getenv("HAL_LIBRARY_PATH");
you could be less intrusive and preserve more of the original code with just the
addition of the code to read from the environment variable? And defaults for
CrOS in a #ifdef?

[fjhenigman, 2014-05-02 05:25:20]

On 2014/04/25 21:28:07, rjkroege wrote:
>
https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/incl...
> File third_party/hwcplus/include/cutils/properties.h (left):
> 
>
https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/incl...
> third_party/hwcplus/include/cutils/properties.h:22: #include
> <sys/system_properties.h>
> could you introduce a #define to leave this also compilable on android?
> 
>
https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/incl...
> File third_party/hwcplus/include/system/graphics.h (right):
> 
>
https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/incl...
> third_party/hwcplus/include/system/graphics.h:20: #include <stddef.h>
> same comment: add #ifdef?
> 
>
https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/src/...
> File third_party/hwcplus/src/hardware.c (right):
> 
>
https://codereview.chromium.org/252583002/diff/40001/third_party/hwcplus/src/...
> third_party/hwcplus/src/hardware.c:129: char *base =
getenv("HAL_LIBRARY_PATH");
> you could be less intrusive and preserve more of the original code with just
the
> addition of the code to read from the environment variable? And defaults for
> CrOS in a #ifdef?

Implemented all your suggestions (including
https://codereview.chromium.org/254683002/#msg2) except the last one, for a
CrOS-specific path default.  I think it's better not to clutter hwcplus with
platform-specific stuff (that's also why I haven't put chrome-specific logging
here, just a hook to customize logging).  Instead things can be configured with
compile time -D defines.  Ok?

[rjkroege, 2014-05-02 20:38:26]

I agree with everything except the direction of the #define.

https://codereview.chromium.org/252583002/diff/60001/third_party/hwcplus/incl...
File third_party/hwcplus/include/cutils/properties.h (right):

https://codereview.chromium.org/252583002/diff/60001/third_party/hwcplus/incl...
third_party/hwcplus/include/cutils/properties.h:22: #ifdef ANDROID
I think we want this inverted. ANDROID is the default here. CROS is the
newcomer?

https://codereview.chromium.org/252583002/diff/60001/third_party/hwcplus/src/...
File third_party/hwcplus/src/hardware.c (right):

https://codereview.chromium.org/252583002/diff/60001/third_party/hwcplus/src/...
third_party/hwcplus/src/hardware.c:144: char *hal_library_path =
getenv("HAL_LIBRARY_PATH");
upon reflection, reading from the environment seems like an excellent idea.

[rjkroege, 2014-05-02 20:43:23]

On 2014/05/02 20:38:26, rjkroege wrote:
> I agree with everything except the direction of the #define.
> 
>
https://codereview.chromium.org/252583002/diff/60001/third_party/hwcplus/incl...
> File third_party/hwcplus/include/cutils/properties.h (right):
> 
>
https://codereview.chromium.org/252583002/diff/60001/third_party/hwcplus/incl...
> third_party/hwcplus/include/cutils/properties.h:22: #ifdef ANDROID
> I think we want this inverted. ANDROID is the default here. CROS is the
> newcomer?
> 
>
https://codereview.chromium.org/252583002/diff/60001/third_party/hwcplus/src/...
> File third_party/hwcplus/src/hardware.c (right):
> 
>
https://codereview.chromium.org/252583002/diff/60001/third_party/hwcplus/src/...
> third_party/hwcplus/src/hardware.c:144: char *hal_library_path =
> getenv("HAL_LIBRARY_PATH");
> upon reflection, reading from the environment seems like an excellent idea.

per discussion: as long as there is separation. nb: might have to invert later.

lgtm.

[fjhenigman, 2014-05-04 01:33:35]

The CQ bit was checked by fjhenigman@chromium.org

[commit-bot: I haz the power, 2014-05-04 01:33:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fjhenigman@chromium.org/252583002/60001

[commit-bot: I haz the power, 2014-05-04 05:15:21]

Change committed as 268096

[DaleCurtis, 2014-05-04 18:30:11]

A revert of this CL has been created in
https://codereview.chromium.org/262153002/ by dalecurtis@chromium.org.

The reason for reverting is: Broke check_licenses, since hwcplus_util.c doesn't
have a license.  Please add one.

http://build.chromium.org/p/chromium/builders/Linux/builds/49510/steps/check_....

[fjhenigman, 2014-05-04 20:40:31]

The CQ bit was checked by fjhenigman@chromium.org

[commit-bot: I haz the power, 2014-05-04 20:40:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fjhenigman@chromium.org/252583002/80001

[commit-bot: I haz the power, 2014-05-04 21:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-04 21:29:23]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium

[fjhenigman, 2014-05-05 14:28:59]

The CQ bit was checked by fjhenigman@chromium.org

[commit-bot: I haz the power, 2014-05-05 14:29:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fjhenigman@chromium.org/252583002/80001

[commit-bot: I haz the power, 2014-05-05 17:32:50]

Change committed as 268211