Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 2525823002: [Merge to 2924] Fix unable to delete extensions continuously through keyboard (Closed)

Created:
4 years, 1 month ago by Qiang(Joe) Xu
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge to 2924] Fix unable to delete extensions continuously through keyboard Changes: (1) revert the cl in Issue 2451323002. (2) using a different approach, which is to avoid restorefocusedview call if desktopnativewidget is not active (since that should be handled in HandleActivationChanged call). BUG=665380 TBR=sky@chromium.org TEST=manual test see bug fixed. Also, this reverts the cl in Issue 2451323002, checked that the bug in that issue is not regressed. Review-Url: https://codereview.chromium.org/2517663002 Cr-Commit-Position: refs/heads/master@{#433706} (cherry picked from commit 34ce9a4718f571b8f8ee0f95b6d153aff38223db) Committed: https://chromium.googlesource.com/chromium/src/+/a4466cde03858e1e1754c9498e7aad4c1ea9c251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 3 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
4 years, 1 month ago (2016-11-22 23:30:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a4466cde03858e1e1754c9498e7aad4c1ea9c251 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698