chromeos: Introduce SetClient() on ash::mojom::SystemTray interface

chromeos: Introduce SetClient() on ash::mojom::SystemTray interface

Previously ash would make a direct connection to Chrome (content_browser) to
handle showing system tray menu UI. This is a layering violation and makes
it more difficult to run ash without chrome.

Chrome's SystemTrayClient now explicitly registers itself with ash on startup.
It no longer attempts to reconnect on error; my understanding is that chrome
tolerating an ash crash is not a goal.

BUG=none
TEST=manual, can still open settings via system tray menu

Committed: https://crrev.com/0ebd9e4860776fbf2ca94a34c2ecf8f2d7dc0aaf
Cr-Commit-Position: refs/heads/master@{#434736}

[James Cook, 2016-11-22 23:46:03]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-11-22 23:46:19]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-11-22 23:46:20]

sky, please take a look.

https://codereview.chromium.org/2525813004/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_controller.cc (right):

https://codereview.chromium.org/2525813004/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_controller.cc:119: LOG(ERROR) <<
"SystemTrayClient not bound";
I didn't want to have silent failures when running on a device.

[commit-bot: I haz the power, 2016-11-22 23:46:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-11-23 00:12:52]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 00:13:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 00:17:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 00:17:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[James Cook, 2016-11-23 00:19:55]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 00:20:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 01:09:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:09:29]

Dry run: This issue passed the CQ dry run.

[sky, 2016-11-23 01:27:10]

One question on the LOG(ERROR).

https://codereview.chromium.org/2525813004/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/system_tray_controller.cc (right):

https://codereview.chromium.org/2525813004/diff/40001/ash/common/system/tray/...
ash/common/system/tray/system_tray_controller.cc:119: LOG(ERROR) <<
"SystemTrayClient not bound";
Will this result in a bunch of error logs in tests?

[James Cook, 2016-11-28 18:17:39]

Patchset #2 (id:20001) has been deleted

[James Cook, 2016-11-28 18:24:47]

sky, please take another look.

https://codereview.chromium.org/2525813004/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/system_tray_controller.cc (right):

https://codereview.chromium.org/2525813004/diff/40001/ash/common/system/tray/...
ash/common/system/tray/system_tray_controller.cc:119: LOG(ERROR) <<
"SystemTrayClient not bound";
On 2016/11/23 01:27:09, sky wrote:
> Will this result in a bunch of error logs in tests?

Hmm, good point. I rewrote it not to log.

[sky, 2016-11-28 19:25:38]

LGTM

[James Cook, 2016-11-28 19:27:58]

jamescook@chromium.org changed reviewers:
+ tsepez@chromium.org

[James Cook, 2016-11-28 19:27:58]

tsepez, can I get OWNERS for mojom?

[Tom Sepez, 2016-11-28 19:46:02]

But of course.  LGTM.

[James Cook, 2016-11-28 20:06:06]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:07:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 22:21:35]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480363566096080,
"parent_rev": "e4e389012a00a8d50e7971d496f23d0f48ef61d8", "commit_rev":
"d64aedb6592779d46f83e32ea8cdf834a9d90434"}

[commit-bot: I haz the power, 2016-11-28 22:22:00]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-28 22:23:32]

Description was changed from

==========
chromeos: Introduce SetClient() on ash::mojom::SystemTray interface

Previously ash would make a direct connection to Chrome (content_browser) to
handle showing system tray menu UI. This is a layering violation and makes
it more difficult to run ash without chrome.

Chrome's SystemTrayClient now explicitly registers itself with ash on startup.
It no longer attempts to reconnect on error; my understanding is that chrome
tolerating an ash crash is not a goal.

BUG=none
TEST=manual, can still open settings via system tray menu
==========

to

==========
chromeos: Introduce SetClient() on ash::mojom::SystemTray interface

Previously ash would make a direct connection to Chrome (content_browser) to
handle showing system tray menu UI. This is a layering violation and makes
it more difficult to run ash without chrome.

Chrome's SystemTrayClient now explicitly registers itself with ash on startup.
It no longer attempts to reconnect on error; my understanding is that chrome
tolerating an ash crash is not a goal.

BUG=none
TEST=manual, can still open settings via system tray menu

Committed: https://crrev.com/0ebd9e4860776fbf2ca94a34c2ecf8f2d7dc0aaf
Cr-Commit-Position: refs/heads/master@{#434736}
==========

[commit-bot: I haz the power, 2016-11-28 22:23:33]

Patchset 4 (id:??) landed as
https://crrev.com/0ebd9e4860776fbf2ca94a34c2ecf8f2d7dc0aaf
Cr-Commit-Position: refs/heads/master@{#434736}