MD Settings: Hide Profile Shortcut switch for single-profile machines.

MD Settings: Hide Profile Shortcut switch for single-profile machines.

The Profile Shortcut switch should be hidden for single-profile
machines. This is a regression from Old Options.

BUG=666264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8171ffd98a17ea9944d346994065b9e8050ca183
Cr-Commit-Position: refs/heads/master@{#434280}

[tommycli, 2016-11-22 22:30:15]

Description was changed from

==========
MD Settings: Hide Profile Shortcut switch for single-profile machines.

The Profile Shortcut switch should be hidden for single-profile
machines. This is a regression from Old Options.

BUG=666264
==========

to

==========
MD Settings: Hide Profile Shortcut switch for single-profile machines.

The Profile Shortcut switch should be hidden for single-profile
machines. This is a regression from Old Options.

BUG=666264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-11-22 22:30:34]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:31:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-22 23:36:07]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-11-22 23:36:07]

dbeam: PTAL. I'm still waiting on my bit9 and admin exceptions for my Windows
box, so I was not able to test manually locally...

This will want a merge back to M56 btw.

[commit-bot: I haz the power, 2016-11-22 23:58:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:58:57]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-11-23 00:29:17]

https://codereview.chromium.org/2525783002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/2525783002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/manage_profile.js:60:
isProfileShortcutSettingVisible_: false,
this should either be

isProfileShortcutSettingVisible_: Boolean,

OR

isProfileShortcutSettingVisible_: {
  type: Boolean,
  value: false,
},

[tommycli, 2016-11-23 19:00:13]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 19:00:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-23 19:00:47]

dbeam: Thanks. I have confirmed manually on Windows that it works now.

(after the latest patchset)

https://codereview.chromium.org/2525783002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/2525783002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/manage_profile.js:60:
isProfileShortcutSettingVisible_: false,
On 2016/11/23 00:29:16, Dan Beam wrote:
> this should either be
> 
> isProfileShortcutSettingVisible_: Boolean,
> 
> OR
> 
> isProfileShortcutSettingVisible_: {
>   type: Boolean,
>   value: false,
> },

Done.

[commit-bot: I haz the power, 2016-11-23 20:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 20:52:55]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-11-23 21:08:05]

lgtm

[tommycli, 2016-11-23 22:05:13]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-11-23 22:06:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 23:44:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479938713933430,
"parent_rev": "b5892a760355b263c7b546d81c6279a4dd41024c", "commit_rev":
"8a8e261c33f1c83e4e0b87bc6be318d96be86297"}

[commit-bot: I haz the power, 2016-11-23 23:44:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-23 23:47:19]

Description was changed from

==========
MD Settings: Hide Profile Shortcut switch for single-profile machines.

The Profile Shortcut switch should be hidden for single-profile
machines. This is a regression from Old Options.

BUG=666264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Hide Profile Shortcut switch for single-profile machines.

The Profile Shortcut switch should be hidden for single-profile
machines. This is a regression from Old Options.

BUG=666264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8171ffd98a17ea9944d346994065b9e8050ca183
Cr-Commit-Position: refs/heads/master@{#434280}
==========

[commit-bot: I haz the power, 2016-11-23 23:47:20]

Patchset 3 (id:??) landed as
https://crrev.com/8171ffd98a17ea9944d346994065b9e8050ca183
Cr-Commit-Position: refs/heads/master@{#434280}