Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2525753002: Restore original opacity when exiting overview (Closed)

Created:
4 years, 1 month ago by oshima
Modified:
4 years, 1 month ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore original opacity when exiting overview BUG=667526 R=varkha@chromium.org TEST=Updated WindowSelectorTest.BasicTextFiltering Committed: https://crrev.com/355b36934b8f321a7970679f9a13fa8768a1c384 Cr-Commit-Position: refs/heads/master@{#434025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M ash/common/wm/overview/scoped_transform_overview_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
oshima
4 years, 1 month ago (2016-11-22 21:52:45 UTC) #1
varkha
-verkha@ +varkha@ Thanks for adding a test for this! LGTM.
4 years, 1 month ago (2016-11-22 22:52:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525753002/1
4 years, 1 month ago (2016-11-22 23:26:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 23:52:52 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 23:55:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/355b36934b8f321a7970679f9a13fa8768a1c384
Cr-Commit-Position: refs/heads/master@{#434025}

Powered by Google App Engine
This is Rietveld 408576698