Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: net/socket/client_socket_pool_base.cc

Issue 2525743002: Make URLRequestContext a MemoryDumpProvider (Abandoned) (Closed)
Patch Set: self review Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_pool_base.cc
diff --git a/net/socket/client_socket_pool_base.cc b/net/socket/client_socket_pool_base.cc
index 165ea53a7a9d7639a7bd4c1c0a456455b0136317..e1318b5721f373f9e7d363aa867161a61f3be88a 100644
--- a/net/socket/client_socket_pool_base.cc
+++ b/net/socket/client_socket_pool_base.cc
@@ -14,8 +14,11 @@
#include "base/metrics/histogram_macros.h"
#include "base/single_thread_task_runner.h"
#include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
+#include "base/trace_event/memory_allocator_dump.h"
+#include "base/trace_event/process_memory_dump.h"
#include "base/trace_event/trace_event.h"
#include "base/values.h"
#include "net/base/net_errors.h"
@@ -697,6 +700,31 @@ ClientSocketPoolBaseHelper::GetInfoAsValue(const std::string& name,
return dict;
}
+void ClientSocketPoolBaseHelper::DumpMemoryStats(
+ base::trace_event::MemoryAllocatorDump* dump) const {
+ base::trace_event::MemoryAllocatorDump* socket_pool_dump = nullptr;
+ size_t socket_count = 0;
+ for (GroupMap::const_iterator it = group_map_.begin(); it != group_map_.end();
+ ++it) {
+ const std::list<IdleSocket> sockets = it->second->idle_sockets();
+ for (auto socket : sockets) {
+ // Only creates a MemoryAllocatorDump if there is at least one idle socket
+ if (!socket_pool_dump) {
+ socket_pool_dump =
+ dump->process_memory_dump()->CreateAllocatorDump(base::StringPrintf(
+ "%s/socket_pool", dump->absolute_name().c_str()));
+ }
+ socket.socket->DumpMemoryStats(socket_pool_dump);
+ ++socket_count;
+ }
+ }
+ if (socket_pool_dump) {
+ socket_pool_dump->AddScalar(
+ base::trace_event::MemoryAllocatorDump::kNameObjectCount,
+ base::trace_event::MemoryAllocatorDump::kUnitsObjects, socket_count);
+ }
+}
+
bool ClientSocketPoolBaseHelper::IdleSocket::IsUsable() const {
if (socket->WasEverUsed())
return socket->IsConnectedAndIdle();

Powered by Google App Engine
This is Rietveld 408576698