Make URLRequestContext a MemoryDumpProvider (Abandoned)

net/http/http_network_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_session.h"
 
 #include <utility>
 
 #include "base/atomic_sequence_num.h"
 #include "base/compiler_specific.h"
 #include "base/debug/stack_trace.h"
 #include "base/logging.h"
 #include "base/memory/memory_coordinator_client_registry.h"
 #include "base/memory/ptr_util.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
+#include "base/trace_event/memory_allocator_dump.h"
+#include "base/trace_event/process_memory_dump.h"
 #include "base/values.h"
 #include "net/base/network_throttle_manager_impl.h"
 #include "net/http/http_auth_handler_factory.h"
 #include "net/http/http_response_body_drainer.h"
 #include "net/http/http_stream_factory_impl.h"
 #include "net/http/url_security_manager.h"
 #include "net/proxy/proxy_service.h"
 #include "net/quic/chromium/quic_stream_factory.h"
 #include "net/quic/core/crypto/quic_random.h"
 #include "net/quic/core/quic_clock.h"
@@ skipping 346 matching lines @@
   ssl_config_service_->GetSSLConfig(server_config);
   GetAlpnProtos(&server_config->alpn_protos);
   *proxy_config = *server_config;
   if (request.privacy_mode == PRIVACY_MODE_ENABLED) {
     server_config->channel_id_enabled = false;
   } else if (params_.enable_token_binding && params_.channel_id_service) {
     server_config->token_binding_params.push_back(TB_PARAM_ECDSAP256);
   }
 }
 
+void HttpNetworkSession::DumpMemoryStats(
+    base::trace_event::MemoryAllocatorDump* url_request_context_dump) const {
+  std::string name = base::StringPrintf("net/http_network_session_%p", this);
+  base::trace_event::MemoryAllocatorDump* http_network_session_dump =
+      url_request_context_dump->process_memory_dump()->GetAllocatorDump(name);
+  // If |this| is shared with another URLRequestContext, add an Ownership Edge
+  // and return early.
+  if (http_network_session_dump != nullptr) {
+    url_request_context_dump->process_memory_dump()->AddOwnershipEdge(
+        url_request_context_dump->guid(), http_network_session_dump->guid());
+    return;
+  }
+  http_network_session_dump =
+      url_request_context_dump->process_memory_dump()->CreateAllocatorDump(
+          name);
+  url_request_context_dump->process_memory_dump()->AddOwnershipEdge(
+      url_request_context_dump->guid(), http_network_session_dump->guid());
+  normal_socket_pool_manager_->DumpMemoryStats(http_network_session_dump);
+}

[ssid, 2016/12/02 21:36:35]

I feel it will look better if it's written as:
if (http_network_session_dump == nullptr) {
  http_network_session_dump = CreateAllocatorDump();
  DumpMemoryStats();
}
AddOwnershipEdge();

+
 ClientSocketPoolManager* HttpNetworkSession::GetSocketPoolManager(
     SocketPoolType pool_type) {
   switch (pool_type) {
     case NORMAL_SOCKET_POOL:
       return normal_socket_pool_manager_.get();
     case WEBSOCKET_SOCKET_POOL:
       return websocket_socket_pool_manager_.get();
     default:
       NOTREACHED();
       break;
@@ skipping 25 matching lines @@
       break;
     case base::MemoryState::SUSPENDED:
     // Note: Not supported at present. Fall through.
     case base::MemoryState::UNKNOWN:
       NOTREACHED();
       break;
   }
 }
 
 }  // namespace net