Make URLRequestContext a MemoryDumpProvider (Abandoned)

net/socket/tcp_client_socket.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/tcp_client_socket.h"
 
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "base/logging.h"
@@ skipping 319 matching lines @@
 void TCPClientSocket::AddConnectionAttempts(
     const ConnectionAttempts& attempts) {
   connection_attempts_.insert(connection_attempts_.begin(), attempts.begin(),
                               attempts.end());
 }
 
 int64_t TCPClientSocket::GetTotalReceivedBytes() const {
   return total_received_bytes_;
 }
 
+void TCPClientSocket::DumpMemoryStats(
+    base::trace_event::MemoryAllocatorDump* dump) const {}

[eroman, 2016/11/29 22:22:51]

Presumably this remains to be implemented?

[xunjieli, 2016/11/30 16:02:03]

Acknowledged. I've adopted the non-abstract approach. I will revisit whether we
want to instrument tcp socket.

+
 void TCPClientSocket::DidCompleteConnect(int result) {
   DCHECK_EQ(next_connect_state_, CONNECT_STATE_CONNECT_COMPLETE);
   DCHECK_NE(result, ERR_IO_PENDING);
   DCHECK(!connect_callback_.is_null());
 
   result = DoConnectLoop(result);
   if (result != ERR_IO_PENDING) {
     socket_->EndLoggingMultipleConnectAttempts(result);
     base::ResetAndReturn(&connect_callback_).Run(result);
   }
@@ skipping 39 matching lines @@
 void TCPClientSocket::EmitTCPMetricsHistogramsOnDisconnect() {
   base::TimeDelta rtt;
   if (socket_->GetEstimatedRoundTripTime(&rtt)) {
     UMA_HISTOGRAM_CUSTOM_TIMES("Net.TcpRtt.AtDisconnect", rtt,
                                base::TimeDelta::FromMilliseconds(1),
                                base::TimeDelta::FromMinutes(10), 100);
   }
 }
 
 }  // namespace net