Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2525723005: Makes delay commitText/setComposition can deal with empty text/composition. (Closed)

Created:
4 years ago by Shu Chen
Modified:
4 years ago
Reviewers:
Azure Wei
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes delay commitText/setComposition can deal with empty text/composition. BUG=668036 Committed: https://crrev.com/89a156914461e445488deeca97a453997540e010 Cr-Commit-Position: refs/heads/master@{#434426}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/ui/input_method/input_method_engine.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/input_method/input_method_engine_base.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/input_method/input_method_engine_base.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (22 generated)
Shu Chen
Please review this cl, thanks!
4 years ago (2016-11-23 07:14:49 UTC) #2
Azure Wei
https://codereview.chromium.org/2525723005/diff/1/chrome/browser/ui/input_method/input_method_engine.cc File chrome/browser/ui/input_method/input_method_engine.cc (right): https://codereview.chromium.org/2525723005/diff/1/chrome/browser/ui/input_method/input_method_engine.cc#newcode152 chrome/browser/ui/input_method/input_method_engine.cc:152: input_context->UpdateCompositionText(composition_, cursor_pos, is_visible); In UpdateCompositionText(), we would send a ...
4 years ago (2016-11-23 07:53:42 UTC) #7
Shu Chen
https://codereview.chromium.org/2525723005/diff/1/chrome/browser/ui/input_method/input_method_engine.cc File chrome/browser/ui/input_method/input_method_engine.cc (right): https://codereview.chromium.org/2525723005/diff/1/chrome/browser/ui/input_method/input_method_engine.cc#newcode152 chrome/browser/ui/input_method/input_method_engine.cc:152: input_context->UpdateCompositionText(composition_, cursor_pos, is_visible); On 2016/11/23 07:53:42, Azure Wei wrote: ...
4 years ago (2016-11-24 02:57:57 UTC) #9
Azure Wei
lgtm
4 years ago (2016-11-24 05:25:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525723005/20001
4 years ago (2016-11-24 08:55:58 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on ...
4 years ago (2016-11-24 10:57:02 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525723005/20001
4 years ago (2016-11-25 00:05:31 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-25 02:36:18 UTC) #29
commit-bot: I haz the power
4 years ago (2016-11-25 02:38:05 UTC) #31
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89a156914461e445488deeca97a453997540e010
Cr-Commit-Position: refs/heads/master@{#434426}

Powered by Google App Engine
This is Rietveld 408576698