|
|
DescriptionMakes delay commitText/setComposition can deal with empty text/composition.
BUG=668036
Committed: https://crrev.com/89a156914461e445488deeca97a453997540e010
Cr-Commit-Position: refs/heads/master@{#434426}
Patch Set 1 #
Total comments: 2
Patch Set 2 : . #
Messages
Total messages: 31 (22 generated)
shuchen@chromium.org changed reviewers: + azurewei@chromium.org
Please review this cl, thanks!
The CQ bit was checked by shuchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2525723005/diff/1/chrome/browser/ui/input_met... File chrome/browser/ui/input_method/input_method_engine.cc (right): https://codereview.chromium.org/2525723005/diff/1/chrome/browser/ui/input_met... chrome/browser/ui/input_method/input_method_engine.cc:152: input_context->UpdateCompositionText(composition_, cursor_pos, is_visible); In UpdateCompositionText(), we would send a faked key event: https://cs.chromium.org/chromium/src/ui/base/ime/input_method_base.cc?q=Updat... Not sure if this is a safe when handing key event.
The CQ bit was checked by shuchen@chromium.org to run a CQ dry run
https://codereview.chromium.org/2525723005/diff/1/chrome/browser/ui/input_met... File chrome/browser/ui/input_method/input_method_engine.cc (right): https://codereview.chromium.org/2525723005/diff/1/chrome/browser/ui/input_met... chrome/browser/ui/input_method/input_method_engine.cc:152: input_context->UpdateCompositionText(composition_, cursor_pos, is_visible); On 2016/11/23 07:53:42, Azure Wei wrote: > In UpdateCompositionText(), we would send a faked key event: > https://cs.chromium.org/chromium/src/ui/base/ime/input_method_base.cc?q=Updat... > Not sure if this is a safe when handing key event. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Avoid delay setComposition if the composition is empty, so that the composition can be cleared correctly. BUG=668036 ========== to ========== Makes delay commitText/setComposition can deal with empty text/composition. BUG=668036 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by shuchen@chromium.org
The CQ bit was unchecked by shuchen@chromium.org
The CQ bit was checked by shuchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by shuchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by shuchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480032317125250, "parent_rev": "91846148ec2c05cdeb65cb24d7437fe88372d1c5", "commit_rev": "3b63774d5ef5d09925fcc077e4c60d940bce18c8"}
Message was sent while issue was closed.
Description was changed from ========== Makes delay commitText/setComposition can deal with empty text/composition. BUG=668036 ========== to ========== Makes delay commitText/setComposition can deal with empty text/composition. BUG=668036 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Makes delay commitText/setComposition can deal with empty text/composition. BUG=668036 ========== to ========== Makes delay commitText/setComposition can deal with empty text/composition. BUG=668036 Committed: https://crrev.com/89a156914461e445488deeca97a453997540e010 Cr-Commit-Position: refs/heads/master@{#434426} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/89a156914461e445488deeca97a453997540e010 Cr-Commit-Position: refs/heads/master@{#434426} |