Move IMMEDIATE_CRASH and OOM_CRASH from wtf to base.

Move IMMEDIATE_CRASH and OOM_CRASH from wtf to base.

Part of the WTF Headers Audit, and needed for moving PartitionAllocator to base.

BUG=632441
R=danakj@chromium.org, yutak@chromium.org

[palmer, 2016-11-22 23:15:26]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 23:15:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[palmer, 2016-11-22 23:16:21]

palmer@chromium.org changed reviewers:
+ danakj@chromium.org, yutak@chromium.org

[palmer, 2016-11-22 23:16:36]

Hopefully a quick and easy review for you. Thanks!

[commit-bot: I haz the power, 2016-11-23 01:36:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:36:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuta Kitamura, 2016-11-24 06:18:29]

LGTM but I'd defer the decision to Dana whether this is
worthwhile addition in base/.

[palmer, 2016-11-28 20:25:34]

> LGTM but I'd defer the decision to Dana whether this is
> worthwhile addition in base/.

The spreadsheet says to convert Assertions.h to base/ equivalents
(https://docs.google.com/spreadsheets/d/1-OyE2MgypFI5B-GfqFGRLgPtpa_aBaFC_uyh9...),
but I don't see an equivalent for OOM_CRASH in base. Although perhaps there is
one that I just didn't see.

I need OOM_CRASH (and hence IMMEDIATE_CRASH, or equivalent) to move
PartitionAlloc to base, but people really object to OOM_CRASH in base I can
change PartitionAlloc to use some other kind of crash. But I'd rather stick with
OOM_CRASH since it seems to be part of how we understand stack traces/crashes,
at least for Windows. danakj, thoughts?

[danakj, 2016-11-28 20:55:06]

https://codereview.chromium.org/2525723004/diff/1/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/2525723004/diff/1/base/logging.h#newcode482
base/logging.h:482: #define LOGGING_CRASH() IMMEDIATE_CRASH()
Just remove this and use IMMEDIATE_CRASH below?

[palmer, 2016-11-28 22:21:33]

https://codereview.chromium.org/2525723004/diff/1/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/2525723004/diff/1/base/logging.h#newcode482
base/logging.h:482: #define LOGGING_CRASH() IMMEDIATE_CRASH()
> Just remove this and use IMMEDIATE_CRASH below?

Done.

[danakj, 2016-11-28 22:28:08]

Thanks.. one more question

https://codereview.chromium.org/2525723004/diff/20001/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/2525723004/diff/20001/base/logging.h#newcode449
base/logging.h:449: #ifndef IMMEDIATE_CRASH
Why the #ifndef?

https://codereview.chromium.org/2525723004/diff/20001/base/logging.h#newcode459
base/logging.h:459: #ifndef OOM_CRASH
same. is there some collision that this is worrying about and we use some other
macro instead? this looks highly confusing but i suspect is not needed?

[palmer, 2016-11-28 22:44:47]

https://codereview.chromium.org/2525723004/diff/20001/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/2525723004/diff/20001/base/logging.h#newcode449
base/logging.h:449: #ifndef IMMEDIATE_CRASH
> Why the #ifndef?

It's only there because it was in the original Blink version. I'm happy to
remove it.

[danakj, 2016-11-28 23:20:07]

Thanks, LGTM w/ 1 more thing

https://codereview.chromium.org/2525723004/diff/40001/base/logging.h
File base/logging.h (left):

https://codereview.chromium.org/2525723004/diff/40001/base/logging.h#oldcode457
base/logging.h:457: // Make all CHECK functions discard their log strings to
reduce code
This comment is still relevant, it is commenting on CHECK() below, so we should
keep the comment here.

[palmer, 2016-11-28 23:25:07]

https://codereview.chromium.org/2525723004/diff/40001/base/logging.h
File base/logging.h (left):

https://codereview.chromium.org/2525723004/diff/40001/base/logging.h#oldcode457
base/logging.h:457: // Make all CHECK functions discard their log strings to
reduce code
> This comment is still relevant, it is commenting on CHECK() below, so we
should keep the comment here.

Argh, oops. Fixed.

[palmer, 2016-11-28 23:25:33]

The CQ bit was checked by palmer@chromium.org

[palmer, 2016-11-28 23:25:34]

The patchset sent to the CQ was uploaded after l-g-t-m from yutak@chromium.org,
danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2525723004/#ps60001
(title: "Restore the necessary comment.")

[commit-bot: I haz the power, 2016-11-28 23:26:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-11-28 23:27:00]

https://codereview.chromium.org/2525723004/diff/60001/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/2525723004/diff/60001/base/logging.h#newcode467
base/logging.h:467: // Make all CHECK functions discard their log strings to
reduce code bloat, and
Heh, sorry. Keep this inside the OFFICIAL_BUILD ifdef where it is true please :)

[danakj, 2016-11-28 23:27:04]

The CQ bit was unchecked by danakj@chromium.org

[palmer, 2016-11-28 23:30:40]

https://codereview.chromium.org/2525723004/diff/60001/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/2525723004/diff/60001/base/logging.h#newcode467
base/logging.h:467: // Make all CHECK functions discard their log strings to
reduce code bloat, and
> Heh, sorry. Keep this inside the OFFICIAL_BUILD ifdef where it is true please
:)

Done.

[palmer, 2016-11-28 23:36:05]

The CQ bit was checked by palmer@chromium.org

[palmer, 2016-11-28 23:36:05]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/2525723004/#ps80001
(title: "Everything in its right place.")

[commit-bot: I haz the power, 2016-11-28 23:36:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-11-29 00:54:00]

Thanks :) LGTM

[commit-bot: I haz the power, 2016-11-29 01:39:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 01:39:21]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[palmer, 2016-11-29 01:43:16]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2016-11-29 01:44:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:24:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[palmer, 2016-11-29 03:05:07]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2016-11-29 03:05:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 05:14:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 05:14:43]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2016-11-29 20:51:49]

Description was changed from

==========
Move IMMEDIATE_CRASH and OOM_CRASH from wtf to base.

Part of the WTF Headers Audit, and needed for moving PartitionAllocator to base.

BUG=632441
==========

to

==========
Move IMMEDIATE_CRASH and OOM_CRASH from wtf to base.

Part of the WTF Headers Audit, and needed for moving PartitionAllocator to base.

BUG=632441
R=danakj@chromium.org, yutak@chromium.org

Committed: https://crrev.com/61343b095788170874ce18d6ffd86963cba14141
Cr-Commit-Position: refs/heads/master@{#435077}
==========

[commit-bot: I haz the power, 2016-11-29 20:51:50]

Patchset 5 (id:??) landed as
https://crrev.com/61343b095788170874ce18d6ffd86963cba14141
Cr-Commit-Position: refs/heads/master@{#435077}

[palmer, 2016-11-29 20:53:31]

Description was changed from

==========
Move IMMEDIATE_CRASH and OOM_CRASH from wtf to base.

Part of the WTF Headers Audit, and needed for moving PartitionAllocator to base.

BUG=632441
R=danakj@chromium.org, yutak@chromium.org

Committed: https://crrev.com/61343b095788170874ce18d6ffd86963cba14141
Cr-Commit-Position: refs/heads/master@{#435077}
==========

to

==========
Move IMMEDIATE_CRASH and OOM_CRASH from wtf to base.

Part of the WTF Headers Audit, and needed for moving PartitionAllocator to base.

BUG=632441
R=danakj@chromium.org, yutak@chromium.org
==========

[palmer, 2016-11-29 20:53:32]

Committed patchset #5 (id:80001) to pending queue manually as
511e3320f65b56d34d33e08270b85e92099dd809 (presubmit successful).