Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2525703002: Enable caching for some Swarming UI content (Closed)

Created:
4 years ago by kjlubick
Modified:
4 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Enable caching for some Swarming UI content BUG=667631 Committed: https://github.com/luci/luci-py/commit/f47d1dcc84b711d1d3289e0ca3147a3be7e1d349

Patch Set 1 #

Total comments: 1

Patch Set 2 : y #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M appengine/swarming/app.yaml View 1 2 chunks +3 lines, -0 lines 0 comments Download
M appengine/swarming/handlers_frontend.py View 1 6 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kjlubick
4 years ago (2016-11-22 17:25:07 UTC) #2
M-A Ruel
https://codereview.chromium.org/2525703002/diff/1/appengine/swarming/app.yaml File appengine/swarming/app.yaml (right): https://codereview.chromium.org/2525703002/diff/1/appengine/swarming/app.yaml#newcode14 appengine/swarming/app.yaml:14: default_expiration: "2d" That's too long, when we push an ...
4 years ago (2016-11-22 17:27:52 UTC) #3
kjlubick
On 2016/11/22 at 17:27:52, maruel wrote: > https://codereview.chromium.org/2525703002/diff/1/appengine/swarming/app.yaml > File appengine/swarming/app.yaml (right): > > https://codereview.chromium.org/2525703002/diff/1/appengine/swarming/app.yaml#newcode14 ...
4 years ago (2016-11-22 17:46:26 UTC) #4
M-A Ruel
lgtm
4 years ago (2016-11-22 18:44:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525703002/20001
4 years ago (2016-11-22 18:45:30 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-22 18:49:48 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/f47d1dcc84b711d1d3289e0ca3147a3be7e1d349

Powered by Google App Engine
This is Rietveld 408576698