Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2525693002: Use single unit/node/element. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -155 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +39 lines, -58 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +7 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 8 chunks +44 lines, -54 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 2 chunks +19 lines, -29 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-22 16:56:42 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-22 17:00:47 UTC) #2
scheglov
4 years, 1 month ago (2016-11-22 17:13:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab0a8e775f7779e1f264e663afad79661be73e67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698