Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2525673002:
Reland of move unused build override (Closed)
|
Created:
4 years, 1 month ago by kthelgason_chromium Modified:
4 years ago CC:
chromium-reviews, kjellander_chromium Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland of move unused build override (patchset #1 id:1 of https://codereview.chromium.org/2520383002/ )
Reason for revert:
Reland after fixing mac builds.
Original issue's description:
> Revert of Remove unused build override (patchset #2 id:20001 of https://codereview.chromium.org/2498603002/ )
>
> Reason for revert:
> This breaks all the Mac builds.
>
> /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen //out/Debug-iphonesimulator --check
> -> returned 1
> ERROR at //build/config/mac/mac_sdk.gni:18:27: Undefined identifier
> mac_deployment_target = mac_deployment_target_build_override
> ^-----------------------------------
> See //build/toolchain/mac/BUILD.gn:14:1: whence it was imported.
> import("//build/config/mac/mac_sdk.gni")
> ^--------------------------------------
> See //BUILD.gn:73:1: which caused the file to be included.
> group("gn_all") {
> ^----------------
> GN gen failed: 1
>
> Original issue's description:
> > Remove unused build override
> >
> > The only downstream project using this used to be WebRTC, where it's no
> > longer needed.
> >
> > BUG=webrtc:6431
> > NOTRY=true
> >
> > Committed: https://crrev.com/6dd0024530bfa1d1f88840204633788bad70239e
> > Cr-Commit-Position: refs/heads/master@{#433856}
>
> TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,kthelgason@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6431
>
> Committed: https://crrev.com/5638488a75f3e1424bedc0607e2183b9d0ad8f4a
> Cr-Commit-Position: refs/heads/master@{#433861}
TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,avi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=webrtc:6431
Committed: https://crrev.com/e3f40e988d9487bfa030e714152fadc458d90e4a
Cr-Commit-Position: refs/heads/master@{#434157}
Patch Set 1 #Patch Set 2 : Fix mac build issues #
Total comments: 1
Patch Set 3 : Rewrap comment #Messages
Total messages: 24 (16 generated)
Created Reland of move unused build override
The CQ bit was checked by kthelgason@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Reland of move unused build override (patchset #1 id:1 of https://codereview.chromium.org/2520383002/ ) Reason for revert: Reland after fixing mac builds. Original issue's description: > Revert of Remove unused build override (patchset #2 id:20001 of https://codereview.chromium.org/2498603002/ ) > > Reason for revert: > This breaks all the Mac builds. > > /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen //out/Debug-iphonesimulator --check > -> returned 1 > ERROR at //build/config/mac/mac_sdk.gni:18:27: Undefined identifier > mac_deployment_target = mac_deployment_target_build_override > ^----------------------------------- > See //build/toolchain/mac/BUILD.gn:14:1: whence it was imported. > import("//build/config/mac/mac_sdk.gni") > ^-------------------------------------- > See //BUILD.gn:73:1: which caused the file to be included. > group("gn_all") { > ^---------------- > GN gen failed: 1 > > Original issue's description: > > Remove unused build override > > > > The only downstream project using this used to be WebRTC, where it's no > > longer needed. > > > > BUG=webrtc:6431 > > NOTRY=true > > > > Committed: https://crrev.com/6dd0024530bfa1d1f88840204633788bad70239e > > Cr-Commit-Position: refs/heads/master@{#433856} > > TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,kthelg... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6431 > > Committed: https://crrev.com/5638488a75f3e1424bedc0607e2183b9d0ad8f4a > Cr-Commit-Position: refs/heads/master@{#433861} TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,avi@ch... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6431 ========== to ========== Reland of move unused build override (patchset #1 id:1 of https://codereview.chromium.org/2520383002/ ) Reason for revert: Reland after fixing mac builds. Original issue's description: > Revert of Remove unused build override (patchset #2 id:20001 of https://codereview.chromium.org/2498603002/ ) > > Reason for revert: > This breaks all the Mac builds. > > /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen //out/Debug-iphonesimulator --check > -> returned 1 > ERROR at //build/config/mac/mac_sdk.gni:18:27: Undefined identifier > mac_deployment_target = mac_deployment_target_build_override > ^----------------------------------- > See //build/toolchain/mac/BUILD.gn:14:1: whence it was imported. > import("//build/config/mac/mac_sdk.gni") > ^-------------------------------------- > See //BUILD.gn:73:1: which caused the file to be included. > group("gn_all") { > ^---------------- > GN gen failed: 1 > > Original issue's description: > > Remove unused build override > > > > The only downstream project using this used to be WebRTC, where it's no > > longer needed. > > > > BUG=webrtc:6431 > > NOTRY=true > > > > Committed: https://crrev.com/6dd0024530bfa1d1f88840204633788bad70239e > > Cr-Commit-Position: refs/heads/master@{#433856} > > TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,kthelg... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6431 > > Committed: https://crrev.com/5638488a75f3e1424bedc0607e2183b9d0ad8f4a > Cr-Commit-Position: refs/heads/master@{#433861} TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,avi@ch... # Skipping CQ checks because original CL landed less than 1 days ago. BUG=webrtc:6431 ==========
The CQ bit was checked by kthelgason@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm https://codereview.chromium.org/2525673002/diff/40001/build_overrides/build.gni File build_overrides/build.gni (right): https://codereview.chromium.org/2525673002/diff/40001/build_overrides/build.g... build_overrides/build.gni:7: # variables can be removed. Re-wrap comment?
The CQ bit was checked by kthelgason@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, avi@chromium.org Link to the patchset: https://codereview.chromium.org/2525673002/#ps60001 (title: "Rewrap comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kthelgason@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479901484779390,
"parent_rev": "159353a6a6d4a624c57844ddfb0029c3e85af8d9", "commit_rev":
"e3da75cc77b5d618af92c418430b383eb5222964"}
Message was sent while issue was closed.
Description was changed from ========== Reland of move unused build override (patchset #1 id:1 of https://codereview.chromium.org/2520383002/ ) Reason for revert: Reland after fixing mac builds. Original issue's description: > Revert of Remove unused build override (patchset #2 id:20001 of https://codereview.chromium.org/2498603002/ ) > > Reason for revert: > This breaks all the Mac builds. > > /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen //out/Debug-iphonesimulator --check > -> returned 1 > ERROR at //build/config/mac/mac_sdk.gni:18:27: Undefined identifier > mac_deployment_target = mac_deployment_target_build_override > ^----------------------------------- > See //build/toolchain/mac/BUILD.gn:14:1: whence it was imported. > import("//build/config/mac/mac_sdk.gni") > ^-------------------------------------- > See //BUILD.gn:73:1: which caused the file to be included. > group("gn_all") { > ^---------------- > GN gen failed: 1 > > Original issue's description: > > Remove unused build override > > > > The only downstream project using this used to be WebRTC, where it's no > > longer needed. > > > > BUG=webrtc:6431 > > NOTRY=true > > > > Committed: https://crrev.com/6dd0024530bfa1d1f88840204633788bad70239e > > Cr-Commit-Position: refs/heads/master@{#433856} > > TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,kthelg... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6431 > > Committed: https://crrev.com/5638488a75f3e1424bedc0607e2183b9d0ad8f4a > Cr-Commit-Position: refs/heads/master@{#433861} TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,avi@ch... # Skipping CQ checks because original CL landed less than 1 days ago. BUG=webrtc:6431 ========== to ========== Reland of move unused build override (patchset #1 id:1 of https://codereview.chromium.org/2520383002/ ) Reason for revert: Reland after fixing mac builds. Original issue's description: > Revert of Remove unused build override (patchset #2 id:20001 of https://codereview.chromium.org/2498603002/ ) > > Reason for revert: > This breaks all the Mac builds. > > /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen //out/Debug-iphonesimulator --check > -> returned 1 > ERROR at //build/config/mac/mac_sdk.gni:18:27: Undefined identifier > mac_deployment_target = mac_deployment_target_build_override > ^----------------------------------- > See //build/toolchain/mac/BUILD.gn:14:1: whence it was imported. > import("//build/config/mac/mac_sdk.gni") > ^-------------------------------------- > See //BUILD.gn:73:1: which caused the file to be included. > group("gn_all") { > ^---------------- > GN gen failed: 1 > > Original issue's description: > > Remove unused build override > > > > The only downstream project using this used to be WebRTC, where it's no > > longer needed. > > > > BUG=webrtc:6431 > > NOTRY=true > > > > Committed: https://crrev.com/6dd0024530bfa1d1f88840204633788bad70239e > > Cr-Commit-Position: refs/heads/master@{#433856} > > TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,kthelg... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6431 > > Committed: https://crrev.com/5638488a75f3e1424bedc0607e2183b9d0ad8f4a > Cr-Commit-Position: refs/heads/master@{#433861} TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,avi@ch... # Skipping CQ checks because original CL landed less than 1 days ago. BUG=webrtc:6431 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Reland of move unused build override (patchset #1 id:1 of https://codereview.chromium.org/2520383002/ ) Reason for revert: Reland after fixing mac builds. Original issue's description: > Revert of Remove unused build override (patchset #2 id:20001 of https://codereview.chromium.org/2498603002/ ) > > Reason for revert: > This breaks all the Mac builds. > > /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen //out/Debug-iphonesimulator --check > -> returned 1 > ERROR at //build/config/mac/mac_sdk.gni:18:27: Undefined identifier > mac_deployment_target = mac_deployment_target_build_override > ^----------------------------------- > See //build/toolchain/mac/BUILD.gn:14:1: whence it was imported. > import("//build/config/mac/mac_sdk.gni") > ^-------------------------------------- > See //BUILD.gn:73:1: which caused the file to be included. > group("gn_all") { > ^---------------- > GN gen failed: 1 > > Original issue's description: > > Remove unused build override > > > > The only downstream project using this used to be WebRTC, where it's no > > longer needed. > > > > BUG=webrtc:6431 > > NOTRY=true > > > > Committed: https://crrev.com/6dd0024530bfa1d1f88840204633788bad70239e > > Cr-Commit-Position: refs/heads/master@{#433856} > > TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,kthelg... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6431 > > Committed: https://crrev.com/5638488a75f3e1424bedc0607e2183b9d0ad8f4a > Cr-Commit-Position: refs/heads/master@{#433861} TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,avi@ch... # Skipping CQ checks because original CL landed less than 1 days ago. BUG=webrtc:6431 ========== to ========== Reland of move unused build override (patchset #1 id:1 of https://codereview.chromium.org/2520383002/ ) Reason for revert: Reland after fixing mac builds. Original issue's description: > Revert of Remove unused build override (patchset #2 id:20001 of https://codereview.chromium.org/2498603002/ ) > > Reason for revert: > This breaks all the Mac builds. > > /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen //out/Debug-iphonesimulator --check > -> returned 1 > ERROR at //build/config/mac/mac_sdk.gni:18:27: Undefined identifier > mac_deployment_target = mac_deployment_target_build_override > ^----------------------------------- > See //build/toolchain/mac/BUILD.gn:14:1: whence it was imported. > import("//build/config/mac/mac_sdk.gni") > ^-------------------------------------- > See //BUILD.gn:73:1: which caused the file to be included. > group("gn_all") { > ^---------------- > GN gen failed: 1 > > Original issue's description: > > Remove unused build override > > > > The only downstream project using this used to be WebRTC, where it's no > > longer needed. > > > > BUG=webrtc:6431 > > NOTRY=true > > > > Committed: https://crrev.com/6dd0024530bfa1d1f88840204633788bad70239e > > Cr-Commit-Position: refs/heads/master@{#433856} > > TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,kthelg... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6431 > > Committed: https://crrev.com/5638488a75f3e1424bedc0607e2183b9d0ad8f4a > Cr-Commit-Position: refs/heads/master@{#433861} TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,avi@ch... # Skipping CQ checks because original CL landed less than 1 days ago. BUG=webrtc:6431 Committed: https://crrev.com/e3f40e988d9487bfa030e714152fadc458d90e4a Cr-Commit-Position: refs/heads/master@{#434157} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e3f40e988d9487bfa030e714152fadc458d90e4a Cr-Commit-Position: refs/heads/master@{#434157} |
