Refactor Reading List Model to use URL as key.

components/reading_list/ios/reading_list_model_impl.h

Index: components/reading_list/ios/reading_list_model_impl.h
diff --git a/components/reading_list/ios/reading_list_model_impl.h b/components/reading_list/ios/reading_list_model_impl.h
index 0c1834148cb7ae533c0eb70eef4eaadf59cf5ae9..5b7aad7b1f663791dd969bb1f75db06d7d0e812d 100644
--- a/components/reading_list/ios/reading_list_model_impl.h
+++ b/components/reading_list/ios/reading_list_model_impl.h
@@ -6,6 +6,7 @@
 #define COMPONENTS_READING_LIST_IOS_READING_LIST_MODEL_IMPL_H_
 
 #include <memory>
+#include <unordered_map>

[jif-google, 2016/11/28 16:28:21]

This is not needed.

 
 #include "components/keyed_service/core/keyed_service.h"
 #include "components/reading_list/ios/reading_list_entry.h"
@@ -33,8 +34,7 @@ class ReadingListModelImpl : public ReadingListModel,
 
   ~ReadingListModelImpl() override;
 
-  void StoreLoaded(std::unique_ptr<ReadingListEntries> unread,
-                   std::unique_ptr<ReadingListEntries> read) override;
+  void StoreLoaded(std::unique_ptr<ReadingListEntries> entries) override;
 
   // KeyedService implementation.
   void Shutdown() override;
@@ -42,29 +42,28 @@ class ReadingListModelImpl : public ReadingListModel,
   // ReadingListModel implementation.
   bool loaded() const override;
 
+  size_t size() const override;
   size_t unread_size() const override;
   size_t read_size() const override;
 
   bool HasUnseenEntries() const override;
   void ResetUnseenEntries() override;
 
+  const ReadingListEntries::iterator begin() const override;
+  const ReadingListEntries::iterator end() const override;
+
+  const ReadingListEntry* GetEntryByURL(const GURL& gurl) const override;
   const ReadingListEntry& GetUnreadEntryAtIndex(size_t index) const override;
   const ReadingListEntry& GetReadEntryAtIndex(size_t index) const override;
-
-  const ReadingListEntry* GetEntryFromURL(const GURL& gurl,
-                                          bool* read) const override;
-
-  bool CallbackEntryURL(
-      const GURL& url,
-      base::Callback<void(const ReadingListEntry&)> callback) const override;
+  void MarkReadByURL(const GURL& url) override;
+  void MarkUnreadByURL(const GURL& url) override;
 
   void RemoveEntryByURL(const GURL& url) override;
 
   const ReadingListEntry& AddEntry(const GURL& url,
                                    const std::string& title) override;
 
-  void MarkReadByURL(const GURL& url) override;
-  void MarkUnreadByURL(const GURL& url) override;
+  void SetReadStatus(const GURL& url, bool read) override;
 
   void SetEntryTitle(const GURL& url, const std::string& title) override;
   void SetEntryDistilledPath(const GURL& url,
@@ -73,10 +72,9 @@ class ReadingListModelImpl : public ReadingListModel,
       const GURL& url,
       ReadingListEntry::DistillationState state) override;
 
-  void SyncAddEntry(std::unique_ptr<ReadingListEntry> entry,
-                    bool read) override;
-  ReadingListEntry* SyncMergeEntry(std::unique_ptr<ReadingListEntry> entry,
-                                   bool read) override;
+  void SyncAddEntry(std::unique_ptr<ReadingListEntry> entry) override;
+  ReadingListEntry* SyncMergeEntry(
+      std::unique_ptr<ReadingListEntry> entry) override;
   void SyncRemoveEntry(const GURL& url) override;
 
   std::unique_ptr<ReadingListModel::ScopedReadingListBatchUpdate>
@@ -106,28 +104,33 @@ class ReadingListModelImpl : public ReadingListModel,
   void SetPersistentHasUnseen(bool has_unseen);
   bool GetPersistentHasUnseen();
 
-  // Returns a mutable pointer to the entry with URL |gurl|. Return nullptr if
-  // no entry is found. If an entry is found, |read| is set to the read status
-  // of the entry.
-  ReadingListEntry* GetMutableEntryFromURL(const GURL& gurl, bool* read) const;
-
-  // Sorts the entries in |read_| and |unread_| according to their |UpdateTime|.
-  void SortEntries();
+  // Returns a mutable pointer to the entry with URL |url|. Return nullptr if
+  // no entry is found.
+  ReadingListEntry* GetMutableEntryFromURL(const GURL& url) const;
 
   // Returns the |storage_layer_| of the model.
   ReadingListModelStorage* StorageLayer();
 
-  // Remove |entry| from the |entries| vector and calls the Move notifications
-  // on observers.
-  void MoveEntryFrom(ReadingListEntries* entries,
-                     const ReadingListEntry& entry,
-                     bool read);
-
   // Remove entry |url| and propagate to store if |from_sync| is false.
   void RemoveEntryByURLImpl(const GURL& url, bool from_sync);
 
-  std::unique_ptr<ReadingListEntries> unread_;
-  std::unique_ptr<ReadingListEntries> read_;
+  void RebuildIndex() const;
+
+  std::unique_ptr<ReadingListEntries> entries_;
+  size_t unread_entry_count_;
+  size_t read_entry_count_;
+
+  // TODO(crbug.com/664924): Remove temporary cache and move it to
+  // ReadingListViewController.
+  struct Cache {
+    Cache();
+    ~Cache();
+    std::vector<GURL> read_entries;
+    std::vector<GURL> unread_entries;
+    bool dirty;
+  };
+  std::unique_ptr<struct Cache> cache_;
+
   std::unique_ptr<ReadingListModelStorage> storage_layer_;
   PrefService* pref_service_;
   bool has_unseen_;