Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: components/reading_list/ios/reading_list_store_delegate.h

Issue 2525663002: Refactor Reading List Model to use URL as key. (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/reading_list/ios/reading_list_store_delegate.h
diff --git a/components/reading_list/ios/reading_list_store_delegate.h b/components/reading_list/ios/reading_list_store_delegate.h
index f1fd28ef2ea2b78c1b178cafd792163b3bf14eb7..ff4b14b52d1f7778303dacc8355af4f299053fa0 100644
--- a/components/reading_list/ios/reading_list_store_delegate.h
+++ b/components/reading_list/ios/reading_list_store_delegate.h
@@ -5,27 +5,27 @@
#ifndef COMPONENTS_READING_LIST_IOS_READING_LIST_STORE_DELEGATE_H_
#define COMPONENTS_READING_LIST_IOS_READING_LIST_STORE_DELEGATE_H_
+#include <map>
+
class ReadingListEntry;
// The delegate to handle callbacks from the ReadingListStore.
class ReadingListStoreDelegate {
public:
+ using ReadingListEntries = std::map<GURL, ReadingListEntry>;
// These three mathods handle callbacks from a ReadingListStore.
- virtual void StoreLoaded(std::unique_ptr<ReadingListEntries> unread,
- std::unique_ptr<ReadingListEntries> read) = 0;
+ virtual void StoreLoaded(std::unique_ptr<ReadingListEntries> entries) = 0;
// Handle sync events.
// Called to add a new entry to the model.
// |entry| must not already exist in the model.
- virtual void SyncAddEntry(std::unique_ptr<ReadingListEntry> entry,
- bool read) = 0;
+ virtual void SyncAddEntry(std::unique_ptr<ReadingListEntry> entry) = 0;
// Called to merge a sync entry with a local entry in the model.
// A local entry with the same URL must exist in the local store and have an
// older UpdateTime.
// Return a pointer to the merged entry.
virtual ReadingListEntry* SyncMergeEntry(
- std::unique_ptr<ReadingListEntry> entry,
- bool read) = 0;
+ std::unique_ptr<ReadingListEntry> entry) = 0;
// Called to remove an entry to the model.
virtual void SyncRemoveEntry(const GURL& url) = 0;
« no previous file with comments | « components/reading_list/ios/reading_list_store.cc ('k') | components/reading_list/ios/reading_list_store_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698