NewTabPage: Remove impression/click ping plumbing for local NTP

chrome/browser/resources/local_ntp/most_visited_single.js

 /* Copyright 2015 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file. */
 
  // Single iframe for NTP tiles.
 (function() {
 'use strict';
 
 
 /**
@@ skipping 65 matching lines @@
  */
 var tiles = null;
 
 
 /**
  * List of parameters passed by query args.
  * @type {Object}
  */
 var queryArgs = {};
 
-/**
- * Url to ping when suggestions have been shown.
- */
-var impressionUrl = null;
-

[mastiz, 2016/11/28 13:46:22]

As discussed offline, I'd prefer if the javascript part gets split to a
dedicated CL.

[Marc Treib, 2016/11/28 13:56:47]

Done.

 
 /**
  * Log an event on the NTP.
  * @param {number} eventType Event from LOG_TYPE.
  */
 var logEvent = function(eventType) {
   chrome.embeddedSearch.newTabPage.logEvent(eventType);
 };
 
 /**
@@ skipping 171 matching lines @@
   parent.appendChild(cur);
   // getComputedStyle causes the initial style (opacity 0) to be applied, so
   // that when we then set it to 1, that triggers the CSS transition.
   if (fadeIn) {
     window.getComputedStyle(cur).opacity;
   }
   cur.style.opacity = 1.0;
 
   // Make sure the tiles variable contain the next tileset we may use.
   tiles = document.createElement('div');
-
-  if (impressionUrl) {
-    navigator.sendBeacon(impressionUrl);
-    impressionUrl = null;
-  }
 };
 
 
 /**
  * Called when the host page wants to add a suggestion tile.
  * For Most Visited, it grabs the data from Chrome and pass on.
  * For host page generated it just passes the data.
  * @param {object} args Data for the tile to be rendered.
  */
 var addTile = function(args) {
@@ skipping 78 matching lines @@
   html.push('<div class="mv-title"></div><div class="mv-thumb"></div>');
   html.push('<div class="mv-x" role="button"></div>');
   tile.innerHTML = html.join('');
   tile.lastElementChild.title = queryArgs['removeTooltip'] || '';
 
   if (isSchemeAllowed(data.url)) {
     tile.href = data.url;
   }
   tile.setAttribute('aria-label', data.title);
   tile.title = data.title;
-  if (data.impressionUrl) {
-    impressionUrl = data.impressionUrl;
-  }
-  if (data.pingUrl) {
-    tile.addEventListener('click', function(ev) {
-      navigator.sendBeacon(data.pingUrl);
-    });
-  }
 
   tile.addEventListener('click', function(ev) {
     logMostVisitedNavigation(position, data.tileSource);
   });
 
   tile.addEventListener('keydown', function(event) {
     if (event.keyCode == 46 /* DELETE */ ||
         event.keyCode == 8 /* BACKSPACE */) {
       event.preventDefault();
       event.stopPropagation();
@@ skipping 202 matching lines @@
     var html = document.querySelector('html');
     html.dir = 'rtl';
   }
 
   window.addEventListener('message', handlePostMessage);
 };
 
 
 window.addEventListener('DOMContentLoaded', init);
 })();