End session on crash if current device-local account no longer exists

End session on crash if current device-local account no longer exists

When a device-local account is removed, its policy is deleted from disk
immediately. If a session using this account happens to be in progress,
the session is allowed to continue with policy served from an in-memory
cache. If Chrome crashes later in the session, the policy becomes
completely unavailable. Exit the session in that case, rather than
allowing it to continue without policy.

BUG=178290
TEST=Manual in VM

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266568

[bartfab (slow), 2014-04-25 13:16:22]

Hi Mattias,

Could you please review?

Hi Nikita,

Could you please give an owner stamp?

[Mattias Nissler (ping if slow), 2014-04-25 14:42:45]

LGTM w/ nit.

https://codereview.chromium.org/252563007/diff/1/chrome/browser/chromeos/chro...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://codereview.chromium.org/252563007/diff/1/chrome/browser/chromeos/chro...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:537:
chrome::AttemptUserExit();
I'd rather put a return here and move the block below out of the else clause.
That'd make it clear that the regular code path is the one below.

[bartfab (slow), 2014-04-25 14:52:52]

https://codereview.chromium.org/252563007/diff/1/chrome/browser/chromeos/chro...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://codereview.chromium.org/252563007/diff/1/chrome/browser/chromeos/chro...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:537:
chrome::AttemptUserExit();
On 2014/04/25 14:42:45, Mattias Nissler wrote:
> I'd rather put a return here and move the block below out of the else clause.
> That'd make it clear that the regular code path is the one below.

Done.

[Nikita (slow), 2014-04-25 15:59:45]

lgtm

[bartfab (slow), 2014-04-28 13:03:13]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-04-28 13:03:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/252563007/40001

[commit-bot: I haz the power, 2014-04-28 14:53:59]

Change committed as 266568