ui/gfx/render_text_mac.h - Issue 252563003: Fix Views inline autocomplete with multi-char graphemes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_mac.h

Issue 252563003: Fix Views inline autocomplete with multi-char graphemes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Extrapolate on the comment. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text_mac.h

diff --git a/ui/gfx/render_text_mac.h b/ui/gfx/render_text_mac.h

index 3a18a0fad45bacf7f9cbbcd4dbf9887b1b01ddb1..ad03b84593549852ce44cdbb6b4dedf60cf81f0e 100644

--- a/ui/gfx/render_text_mac.h

+++ b/ui/gfx/render_text_mac.h

@@ -44,7 +44,7 @@ class RenderTextMac : public RenderText {

virtual std::vector<Rect> GetSubstringBounds(const Range& range) OVERRIDE;

virtual size_t TextIndexToLayoutIndex(size_t index) const OVERRIDE;

virtual size_t LayoutIndexToTextIndex(size_t index) const OVERRIDE;

- virtual bool IsCursorablePosition(size_t position) OVERRIDE;

+ virtual bool IsValidCursorIndex(size_t index) OVERRIDE;

virtual void ResetLayout() OVERRIDE;

virtual void EnsureLayout() OVERRIDE;

virtual void DrawVisualText(Canvas* canvas) OVERRIDE;

« no previous file with comments | « ui/gfx/render_text.cc ('k') | ui/gfx/render_text_mac.cc » ('j') | no next file with comments »