Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: runtime/vm/object.cc

Issue 2525623002: VM: [Kernel] Split kernel API into 3 steps: ([read binary], parse-binary, bootstrap, load program) (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 2b05ec58e92b5dc8489cb2ba6f02f32b2a15ce35..5e7a84491f4cc655001ed0340d0aa150b2b11472 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -1136,14 +1136,12 @@ void Object::RegisterPrivateClass(const Class& cls,
// A non-NULL kernel argument indicates (1). A NULL kernel indicates (2) or
// (3), depending on whether the VM is compiled with DART_NO_SNAPSHOT defined or
// not.
-RawError* Object::Init(Isolate* isolate,
- const uint8_t* kernel_buffer,
- intptr_t kernel_buffer_length) {
+RawError* Object::Init(Isolate* isolate, kernel::Program* kernel_program) {
Thread* thread = Thread::Current();
Zone* zone = thread->zone();
ASSERT(isolate == thread->isolate());
#if !defined(DART_PRECOMPILED_RUNTIME)
- const bool is_kernel = (kernel_buffer != NULL);
+ const bool is_kernel = (kernel_program != NULL);
#endif
NOT_IN_PRODUCT(TimelineDurationScope tds(thread, Timeline::GetIsolateStream(),
"Object::Init");)
@@ -1619,8 +1617,8 @@ RawError* Object::Init(Isolate* isolate,
// Finish the initialization by compiling the bootstrap scripts containing
// the base interfaces and the implementation of the internal classes.
- const Error& error = Error::Handle(
- zone, Bootstrap::DoBootstrapping(kernel_buffer, kernel_buffer_length));
+ const Error& error =
+ Error::Handle(zone, Bootstrap::DoBootstrapping(kernel_program));
if (!error.IsNull()) {
return error.raw();
}
« no previous file with comments | « runtime/vm/object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698