Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2525573002: [runtime] Always normalize prototype maps that aren't marked as 'should be fast' yet (Closed)

Created:
4 years, 1 month ago by Toon Verwaest
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Always normalize prototype maps that aren't marked as 'should be fast' yet This makes the test in the bug ~10x faster. It could inadvertently make other things slower, so revert eagerly if included in a range where performance tanks. BUG=chromium:666852 Committed: https://crrev.com/30d2fb6b509f44194ee5a6a7c1caa6b36fa61074 Cr-Commit-Position: refs/heads/master@{#41178}

Patch Set 1 #

Patch Set 2 : Don't normalize JSGlobalProxy #

Patch Set 3 : minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M src/objects.cc View 1 2 2 chunks +8 lines, -15 lines 0 comments Download
M test/mjsunit/fast-prototype.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Toon Verwaest
ptal
4 years, 1 month ago (2016-11-22 10:00:25 UTC) #2
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-22 10:18:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525573002/1
4 years, 1 month ago (2016-11-22 11:16:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/18293) v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-22 11:34:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525573002/40001
4 years, 1 month ago (2016-11-22 13:00:05 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-22 13:25:02 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 13:25:26 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/30d2fb6b509f44194ee5a6a7c1caa6b36fa61074
Cr-Commit-Position: refs/heads/master@{#41178}

Powered by Google App Engine
This is Rietveld 408576698