mash: Change CastConfigDelegate to a mojoified CastConfigClient.

ash/common/cast_config_controller.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/common/cast_config_controller.h"
+
+#include <utility>
+#include <vector>
+
+#include "base/logging.h"
+#include "content/public/common/service_names.mojom.h"
+#include "services/service_manager/public/cpp/connector.h"
+
+namespace ash {
+
+CastConfigController::CastConfigController() {}
+
+CastConfigController::~CastConfigController() {}
+
+bool CastConfigController::Connected() {
+  return client_.is_bound();
+}
+
+void CastConfigController::AddObserver(CastConfigControllerObserver* observer) {
+  observers_.AddObserver(observer);
+  if (Connected())

[James Cook, 2016/12/02 04:15:52]

I think if (client_) is a synonym for client_.is_bound(), so maybe this could be
if (client_) and the Connected() method could go away?

[Elliot Glaysher, 2016/12/02 19:23:11]

I can't remove Connected() entirely because it's used in the view code outside
this class.

+    client_->RequestDeviceRefresh();

[James Cook, 2016/12/02 04:15:52]

It's a little weird that this is a side effect of adding an observer. I think it
would be clearer for callers to AddObserver to explicitly call
RequestDeviceRefresh() as well.

If that's too verbose or won't work for some reason, then document the side
effect by AddObserver in the header.

[Elliot Glaysher, 2016/12/02 19:23:11]

Done.

+}
+
+void CastConfigController::RemoveObserver(
+    CastConfigControllerObserver* observer) {
+  observers_.RemoveObserver(observer);
+}
+
+void CastConfigController::BindRequest(mojom::CastConfigRequest request) {
+  bindings_.AddBinding(this, std::move(request));
+}
+
+void CastConfigController::SetClient(
+    mojom::CastConfigClientAssociatedPtrInfo client) {
+  client_.Bind(std::move(client));
+
+  // If we added observers before we were connected to, run them now.
+  if (observers_.might_have_observers())
+    client_->RequestDeviceRefresh();
+}
+
+void CastConfigController::OnDevicesUpdated(
+    std::vector<mojom::SinkAndRoutePtr> devices) {
+  for (auto& observer : observers_) {
+    std::vector<mojom::SinkAndRoutePtr> devices_copy;
+    for (auto& item : devices)
+      devices_copy.push_back(item.Clone());
+    observer.OnDevicesUpdated(std::move(devices_copy));
+  }
+}
+
+void CastConfigController::RequestDeviceRefresh() {
+  if (client_)
+    client_->RequestDeviceRefresh();
+}
+
+void CastConfigController::CastToSink(ash::mojom::CastSinkPtr sink) {
+  if (client_)
+    client_->CastToSink(std::move(sink));
+}
+
+void CastConfigController::StopCasting(ash::mojom::CastRoutePtr route) {
+  if (client_)
+    client_->StopCasting(std::move(route));
+}
+
+void CastConfigController::OnClientConnectionError() {
+  client_.reset();
+}
+
+}  // namespace ash