Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 2525543002: [DevTools] remove old console.assert hack (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] remove old console.assert hack New console.assert implementation is faster then any hacks. BUG=chromium:663845 R=lushnikov@chromium.org Committed: https://crrev.com/b66d8ae9dc168c81845b28f36fcc9ae27522afd2 Cr-Commit-Position: refs/heads/master@{#435081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M third_party/WebKit/Source/devtools/front_end/platform/utilities.js View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kozy
Andrey, please take a look! V8 part: https://codereview.chromium.org/2505493002/
4 years, 1 month ago (2016-11-22 06:58:56 UTC) #1
lushnikov
✨🎈 lgtm 🎉
4 years, 1 month ago (2016-11-22 20:03:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525543002/1
4 years ago (2016-11-29 19:46:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 21:35:38 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 21:40:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b66d8ae9dc168c81845b28f36fcc9ae27522afd2
Cr-Commit-Position: refs/heads/master@{#435081}

Powered by Google App Engine
This is Rietveld 408576698