Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2525513003: stack: Detect library by name and arch (Closed)

Created:
4 years, 1 month ago by michaelbai
Modified:
4 years ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

stack: Detect library by name and arch We were using name and size to detect library, this didn't work when the relocation section is packed, in this case, the library size doesn't match the one in APK. BUG=663108 Committed: https://crrev.com/3712de4fe0f696d46aba8ae9fb22658fc116596f Cr-Commit-Position: refs/heads/master@{#434088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M third_party/android_platform/development/scripts/stack_core.py View 3 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
michaelbai
4 years, 1 month ago (2016-11-22 22:56:37 UTC) #3
sgurun-gerrit only
On 2016/11/22 22:56:37, michaelbai wrote: lgtm
4 years, 1 month ago (2016-11-22 23:44:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525513003/1
4 years, 1 month ago (2016-11-22 23:48:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 02:31:43 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-23 02:33:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3712de4fe0f696d46aba8ae9fb22658fc116596f
Cr-Commit-Position: refs/heads/master@{#434088}

Powered by Google App Engine
This is Rietveld 408576698