Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 25255002: Emit compile-time errors on illegal variable declarations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/scanner/listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index 3c968cddba9192a4fb00d99dca644131bc23a194..b4fbcd6b8694d7058d2a2bfacad92e18262c048c 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -2743,7 +2743,9 @@ class ResolverVisitor extends MappingVisitor<Element> {
Modifiers modifiers = node.modifiers;
void reportExtraModifier(String modifier) {
Node modifierNode;
- for (var nodes = modifiers.nodes; !nodes.isEmpty; nodes = nodes.tail) {
+ for (Link<Node> nodes = modifiers.nodes.nodes;
+ !nodes.isEmpty;
+ nodes = nodes.tail) {
if (modifier == nodes.head.asIdentifier().source.stringValue) {
modifierNode = nodes.head;
break;
@@ -2759,7 +2761,14 @@ class ResolverVisitor extends MappingVisitor<Element> {
if (modifiers.isVar() && (modifiers.isConst() || node.type != null)) {
reportExtraModifier('var');
}
-
+ if (enclosingElement.isFunction()) {
+ if (modifiers.isAbstract()) {
+ reportExtraModifier('abstract');
+ }
+ if (modifiers.isStatic()) {
+ reportExtraModifier('static');
+ }
+ }
visitor.visit(node.definitions);
}
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/scanner/listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698