Milo: Add themed page for errors

Milo: Add themed page for errors

This way people navigating to 404's will still see the "sign in" link.

BUG=666551
Committed: https://github.com/luci/luci-go/commit/2b85e2e02789e4f20bfd0200569382e0faeb872c

[Ryan Tseng, 2016-11-22 00:32:45]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 00:32:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-11-22 00:33:33]

hinoka@chromium.org changed reviewers:
+ estaab@chromium.org, hinoka@chromium.org

[hinoka, 2016-11-22 00:33:33]

ptal

demo:
https://1258-c34ebd4-tainted-hinoka-dot-luci-milo.appspot.com/buildbot/offici...

Theres a bug somewhere, somehow the code isn't getting propagated correctly.

[hinoka, 2016-11-22 00:34:41]

actually the bug is further in the code.  Not ptal yet, i'll send out another
one when ready.

[commit-bot: I haz the power, 2016-11-22 00:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 00:38:46]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2016-11-22 21:28:44]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 21:28:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-11-22 21:32:35]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 21:32:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 21:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 21:36:37]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Precise 32 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/32a6c63ffec14310)
  Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/32a6c6401b4dd210)
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/32a6c63f67c59f10)

[Ryan Tseng, 2016-11-22 21:41:37]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 21:41:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 21:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 21:48:15]

Dry run: This issue passed the CQ dry run.

[hinoka, 2016-11-22 21:57:48]

Okay ready now

See
https://1258-c34ebd4-tainted-hinoka-dot-luci-milo.appspot.com/buildbot/chromi...

[hinoka, 2016-11-28 23:22:23]

post turkey bump

[hinoka, 2016-11-29 18:00:05]

Description was changed from

==========
Milo: Add themed page for errors

This way people navigating to 404's will still see the "sign in" link.

BUG=
==========

to

==========
Milo: Add themed page for errors

This way people navigating to 404's will still see the "sign in" link.

BUG=666551
==========

[akeshet1, 2016-11-30 23:37:02]

akeshet@google.com changed reviewers:
+ akeshet@google.com

[akeshet1, 2016-11-30 23:37:03]

ping. this is blocking downstream work.

[estaab, 2016-12-01 00:04:34]

https://codereview.chromium.org/2525493002/diff/60001/milo/appengine/buildbot...
File milo/appengine/buildbot/master.go (right):

https://codereview.chromium.org/2525493002/diff/60001/milo/appengine/buildbot...
milo/appengine/buildbot/master.go:56: if cu.Identity ==
identity.AnonymousIdentity {
It seems pretty dangerous to have the auth checking code duplicated. If the
logic changes and we forget to update one we can get into trouble. Can you make
this a CheckAccess() method that's shared between both access sites?

[Ryan Tseng, 2016-12-01 02:08:29]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 02:08:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-12-01 02:08:55]

https://codereview.chromium.org/2525493002/diff/60001/milo/appengine/buildbot...
File milo/appengine/buildbot/master.go (right):

https://codereview.chromium.org/2525493002/diff/60001/milo/appengine/buildbot...
milo/appengine/buildbot/master.go:56: if cu.Identity ==
identity.AnonymousIdentity {
On 2016/12/01 00:04:34, estaab wrote:
> It seems pretty dangerous to have the auth checking code duplicated. If the
> logic changes and we forget to update one we can get into trouble. Can you
make
> this a CheckAccess() method that's shared between both access sites?

Done.

[commit-bot: I haz the power, 2016-12-01 02:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 02:14:29]

Dry run: This issue passed the CQ dry run.

[estaab, 2016-12-01 12:30:10]

lgtm

[hinoka, 2016-12-01 21:09:44]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:09:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 21:13:53]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480626584820440,
"parent_rev": "2568e271f92ed046ea2c10318e90c2f53147eda1", "commit_rev":
"2b85e2e02789e4f20bfd0200569382e0faeb872c"}

[commit-bot: I haz the power, 2016-12-01 21:13:56]

Description was changed from

==========
Milo: Add themed page for errors

This way people navigating to 404's will still see the "sign in" link.

BUG=666551
==========

to

==========
Milo: Add themed page for errors

This way people navigating to 404's will still see the "sign in" link.

BUG=666551

Committed:
https://github.com/luci/luci-go/commit/2b85e2e02789e4f20bfd0200569382e0faeb872c
==========

[commit-bot: I haz the power, 2016-12-01 21:13:57]

Committed patchset #5 (id:80001) as
https://github.com/luci/luci-go/commit/2b85e2e02789e4f20bfd0200569382e0faeb872c