Remove SurfaceTextureManager

Remove SurfaceTextureManager

This CL is a continuation of the cleanup started by
reveman@ in c0329013d5cacd4c6c135e9d130a66ac3e25db4a

The SurfaceTexture implementation of the GpuMemoryBuffer
was the only client of the SurfaceTextureManager.

BUG=608800
,
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a
Cr-Commit-Position: refs/heads/master@{#435991}

[tguilbert, 2016-11-23 02:49:27]

Description was changed from

==========
Remove SurfaceTextureManager

//TODO(tguilbert)

BUG=
==========

to

==========
Remove SurfaceTextureManager

//TODO(tguilbert)

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tguilbert, 2016-11-23 02:50:02]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 02:50:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 04:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 04:27:00]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tguilbert, 2016-11-23 19:26:51]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 19:27:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tguilbert, 2016-11-23 19:46:36]

Description was changed from

==========
Remove SurfaceTextureManager

//TODO(tguilbert)

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove SurfaceTextureManager

This CL is a continuation of the cleanup started by 
reveman@ in c0329013d5cacd4c6c135e9d130a66ac3e25db4a

The SurfaceTexture implementation of the GpuMemoryBuffer
was the only client of the SurfaceTextureManager.

BUG=608800, 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tguilbert, 2016-11-23 19:58:14]

tguilbert@chromium.org changed reviewers:
+ palmer@chromium.org, pfeldman@chromium.org, tsepez@chromium.org,
vmiura@chromium.org

[tguilbert, 2016-11-23 19:58:15]

Hello! PTAL at the following areas

pfeldman, content/*
tsepez, gpu/ipc/common/*
vmiura, gpu/*
palmer, *.aidl

cc as an FYI: reveman, markdittmer

Thank you :)

https://codereview.chromium.org/2525483005/diff/1/content/browser/browser_mai...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2525483005/diff/1/content/browser/browser_mai...
content/browser/browser_main_loop.cc:674: TRACE_EVENT0("startup",
"BrowserMainLoop::Subsystem:SurfaceTextureManager");
Any suggestions as to what this should be updated to?

[Tom Sepez, 2016-11-23 20:23:09]

lgtm

[palmer, 2016-11-23 20:26:37]

lgtm

[tguilbert, 2016-11-28 22:00:20]

On 2016/11/23 20:26:37, palmer wrote:
> lgtm

Ping :)

[tguilbert, 2016-11-29 01:09:47]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 01:10:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:50:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:50:55]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tguilbert, 2016-11-29 17:33:08]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 17:33:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 19:13:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 19:13:23]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tguilbert, 2016-11-30 00:58:05]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 00:59:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmiura, 2016-11-30 03:01:30]

gpu/* lgtm

[commit-bot: I haz the power, 2016-11-30 03:03:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 03:03:33]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[reveman, 2016-11-30 17:05:08]

reveman@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-11-30 17:05:08]

thanks for taking care of this. lgtm.

[tguilbert, 2016-12-01 22:46:49]

tguilbert@chromium.org changed reviewers:
+ nick@chromium.org

[tguilbert, 2016-12-01 22:46:50]

@nick, can you OWNERS review content/*? This is mostly deletion of files (except
for content/app/android/child_process_service_impl.cc). There is also one
comment from patch #1 that I carried over into patch #4.

Thank you!
Thomas

https://codereview.chromium.org/2525483005/diff/60001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2525483005/diff/60001/content/browser/browser...
content/browser/browser_main_loop.cc:676: TRACE_EVENT0("startup",
"BrowserMainLoop::Subsystem:SurfaceTextureManager");
Carrying over this comment from Patch #1. Any suggestions as to how this should
be renamed?

[ncarter (slow), 2016-12-01 23:20:08]

lgtm

https://codereview.chromium.org/2525483005/diff/60001/content/app/android/chi...
File content/app/android/child_process_service_impl.cc (right):

https://codereview.chromium.org/2525483005/diff/60001/content/app/android/chi...
content/app/android/child_process_service_impl.cc:38: // we're in a renderer or
gpu process.
Is this TODO still relevant?

https://codereview.chromium.org/2525483005/diff/60001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2525483005/diff/60001/content/browser/browser...
content/browser/browser_main_loop.cc:676: TRACE_EVENT0("startup",
"BrowserMainLoop::Subsystem:SurfaceTextureManager");
On 2016/12/01 22:46:50, tguilbert wrote:
> Carrying over this comment from Patch #1. Any suggestions as to how this
should
> be renamed?

"BrowserMainLoop::Subsystem:BrowserMediaPlayerManager"

I assume nobody cares about single-process when they are looking at tracing, so
just name it after what happens on line 681.

https://codereview.chromium.org/2525483005/diff/60001/gpu/command_buffer/comm...
File gpu/command_buffer/common/unittest_main.cc (right):

https://codereview.chromium.org/2525483005/diff/60001/gpu/command_buffer/comm...
gpu/command_buffer/common/unittest_main.cc:32: void GpuTestSuite::Initialize() {
Looks like you can delete this override.

[tguilbert, 2016-12-02 00:01:52]

+liberato as an FYI, since this will cause a conflict with
https://codereview.chromium.org/2178973004/.

I will wait for an ACK before submitting.

https://codereview.chromium.org/2525483005/diff/60001/content/app/android/chi...
File content/app/android/child_process_service_impl.cc (right):

https://codereview.chromium.org/2525483005/diff/60001/content/app/android/chi...
content/app/android/child_process_service_impl.cc:38: // we're in a renderer or
gpu process.
On 2016/12/01 23:20:08, ncarter wrote:
> Is this TODO still relevant?

I am not 100% sure. I will leave it as is for the moment. I will be deleting
gpu::SurfaceTexturePeer in 2017 and will be revisiting this code anyways.

https://codereview.chromium.org/2525483005/diff/60001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2525483005/diff/60001/content/browser/browser...
content/browser/browser_main_loop.cc:676: TRACE_EVENT0("startup",
"BrowserMainLoop::Subsystem:SurfaceTextureManager");
On 2016/12/01 23:20:08, ncarter wrote:
> On 2016/12/01 22:46:50, tguilbert wrote:
> > Carrying over this comment from Patch #1. Any suggestions as to how this
> should
> > be renamed?
> 
> "BrowserMainLoop::Subsystem:BrowserMediaPlayerManager"
> 
> I assume nobody cares about single-process when they are looking at tracing,
so
> just name it after what happens on line 681.

Sounds good. (Although, I will be deleting line 681 eventually. I will revisit
this problem then).

https://codereview.chromium.org/2525483005/diff/60001/gpu/command_buffer/comm...
File gpu/command_buffer/common/unittest_main.cc (right):

https://codereview.chromium.org/2525483005/diff/60001/gpu/command_buffer/comm...
gpu/command_buffer/common/unittest_main.cc:32: void GpuTestSuite::Initialize() {
On 2016/12/01 23:20:08, ncarter wrote:
> Looks like you can delete this override.

Done.

[liberato (no reviews please), 2016-12-02 00:59:09]

On 2016/12/02 00:01:52, tguilbert wrote:
> +liberato as an FYI, since this will cause a conflict with
> https://codereview.chromium.org/2178973004/.
> 
> I will wait for an ACK before submitting.
> 
>
https://codereview.chromium.org/2525483005/diff/60001/content/app/android/chi...
> File content/app/android/child_process_service_impl.cc (right):
> 
>
https://codereview.chromium.org/2525483005/diff/60001/content/app/android/chi...
> content/app/android/child_process_service_impl.cc:38: // we're in a renderer
or
> gpu process.
> On 2016/12/01 23:20:08, ncarter wrote:
> > Is this TODO still relevant?
> 
> I am not 100% sure. I will leave it as is for the moment. I will be deleting
> gpu::SurfaceTexturePeer in 2017 and will be revisiting this code anyways.
> 
>
https://codereview.chromium.org/2525483005/diff/60001/content/browser/browser...
> File content/browser/browser_main_loop.cc (right):
> 
>
https://codereview.chromium.org/2525483005/diff/60001/content/browser/browser...
> content/browser/browser_main_loop.cc:676: TRACE_EVENT0("startup",
> "BrowserMainLoop::Subsystem:SurfaceTextureManager");
> On 2016/12/01 23:20:08, ncarter wrote:
> > On 2016/12/01 22:46:50, tguilbert wrote:
> > > Carrying over this comment from Patch #1. Any suggestions as to how this
> > should
> > > be renamed?
> > 
> > "BrowserMainLoop::Subsystem:BrowserMediaPlayerManager"
> > 
> > I assume nobody cares about single-process when they are looking at tracing,
> so
> > just name it after what happens on line 681.
> 
> Sounds good. (Although, I will be deleting line 681 eventually. I will revisit
> this problem then).
> 
>
https://codereview.chromium.org/2525483005/diff/60001/gpu/command_buffer/comm...
> File gpu/command_buffer/common/unittest_main.cc (right):
> 
>
https://codereview.chromium.org/2525483005/diff/60001/gpu/command_buffer/comm...
> gpu/command_buffer/common/unittest_main.cc:32: void GpuTestSuite::Initialize()
{
> On 2016/12/01 23:20:08, ncarter wrote:
> > Looks like you can delete this override.
> 
> Done.

thanks for the heads up.  please land and i'll deal with the conflicts.

[tguilbert, 2016-12-02 01:03:19]

The CQ bit was checked by tguilbert@chromium.org

[tguilbert, 2016-12-02 01:03:19]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
tsepez@chromium.org, reveman@chromium.org, vmiura@chromium.org,
nick@chromium.org
Link to the patchset: https://codereview.chromium.org/2525483005/#ps80001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-12-02 01:03:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 01:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 01:14:01]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tguilbert, 2016-12-02 01:27:16]

The CQ bit was checked by tguilbert@chromium.org

[tguilbert, 2016-12-02 01:27:16]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org,
reveman@chromium.org, palmer@chromium.org, vmiura@chromium.org,
tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2525483005/#ps100001
(title: "Fix link error")

[commit-bot: I haz the power, 2016-12-02 01:28:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 04:45:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 04:45:12]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tguilbert, 2016-12-02 18:23:09]

The CQ bit was checked by tguilbert@chromium.org

[commit-bot: I haz the power, 2016-12-02 18:23:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 19:25:26]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480702989941430,
"parent_rev": "ad8fc528026e73f0377406a529f7eaf1fbff2dc3", "commit_rev":
"f7193808574d772971a58149e6edb0eda2ba00e5"}

[commit-bot: I haz the power, 2016-12-02 19:25:52]

Description was changed from

==========
Remove SurfaceTextureManager

This CL is a continuation of the cleanup started by 
reveman@ in c0329013d5cacd4c6c135e9d130a66ac3e25db4a

The SurfaceTexture implementation of the GpuMemoryBuffer
was the only client of the SurfaceTextureManager.

BUG=608800, 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove SurfaceTextureManager

This CL is a continuation of the cleanup started by 
reveman@ in c0329013d5cacd4c6c135e9d130a66ac3e25db4a

The SurfaceTexture implementation of the GpuMemoryBuffer
was the only client of the SurfaceTextureManager.

BUG=608800, 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-02 19:25:55]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-02 19:27:18]

Description was changed from

==========
Remove SurfaceTextureManager

This CL is a continuation of the cleanup started by 
reveman@ in c0329013d5cacd4c6c135e9d130a66ac3e25db4a

The SurfaceTexture implementation of the GpuMemoryBuffer
was the only client of the SurfaceTextureManager.

BUG=608800, 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove SurfaceTextureManager

This CL is a continuation of the cleanup started by
reveman@ in c0329013d5cacd4c6c135e9d130a66ac3e25db4a

The SurfaceTexture implementation of the GpuMemoryBuffer
was the only client of the SurfaceTextureManager.

BUG=608800,
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a
Cr-Commit-Position: refs/heads/master@{#435991}
==========

[commit-bot: I haz the power, 2016-12-02 19:27:20]

Patchset 6 (id:??) landed as
https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a
Cr-Commit-Position: refs/heads/master@{#435991}