Raster: Allow a RasterSource to specify its color space

Raster: Allow a RasterSource to specify its color space

The pictures recorded by GraphicsLayers in Blink have a particular
implied color space in the recorded content. This is the color space
that the decoded images are in (and soon to be the color space that
CSS colors are converted into from sRGB).

We need to communicate that information from Blink to cc, so that
the resulting cc::Resources can be tagged with the appropriate color
space.

Plumb this through the same channel in WebDisplayItemList that is
used for "IsSuitableForGpuRasterization".

Of note is that "true color mode" content (content that does linear
blending) has the luxury of being able to decide the target color
space at raster time -- it does not have an implied color space.

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/b7210d35c666575a48ed600d7758c451220b09b8
Cr-Commit-Position: refs/heads/master@{#435212}

[ccameron, 2016-11-21 22:46:32]

Description was changed from

==========
Add implied color space work

BUG=667411
==========

to

==========
Add implied color space work

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2016-11-21 22:46:57]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 22:47:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 23:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 23:33:54]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-11-22 22:14:56]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:15:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 00:21:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 00:21:52]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-11-23 00:22:07]

Description was changed from

==========
Add implied color space work

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Raster: Allow a RasterSource to specify its color space

The pictures recorded by GraphicsLayers in Blink have a particularimplied color
space in the recorded content. This is the color space
that the decoded images are in (and soon to be the color space that
CSS colors are converted into from sRGB).

We need to communicate that information from Blink to cc, so that
the resulting cc::Resources can be tagged with the appropriate color
space.

Of note is that "true color mode" content (content that does linear
blending) has the luxury of being able to decide the target color
space at raster time -- it does not have an implied color space.

BUG=667411
==========

[ccameron, 2016-11-23 00:22:07]

ccameron@chromium.org changed reviewers:
+ pdr@chromium.org

[ccameron, 2016-11-23 00:22:26]

Description was changed from

==========
Raster: Allow a RasterSource to specify its color space

The pictures recorded by GraphicsLayers in Blink have a particularimplied color
space in the recorded content. This is the color space
that the decoded images are in (and soon to be the color space that
CSS colors are converted into from sRGB).

We need to communicate that information from Blink to cc, so that
the resulting cc::Resources can be tagged with the appropriate color
space.

Of note is that "true color mode" content (content that does linear
blending) has the luxury of being able to decide the target color
space at raster time -- it does not have an implied color space.

BUG=667411
==========

to

==========
Raster: Allow a RasterSource to specify its color space

The pictures recorded by GraphicsLayers in Blink have a particular
implied color space in the recorded content. This is the color space
that the decoded images are in (and soon to be the color space that
CSS colors are converted into from sRGB).

We need to communicate that information from Blink to cc, so that
the resulting cc::Resources can be tagged with the appropriate color
space.

Of note is that "true color mode" content (content that does linear
blending) has the luxury of being able to decide the target color
space at raster time -- it does not have an implied color space.

BUG=667411
==========

[ccameron, 2016-11-23 00:23:27]

Description was changed from

==========
Raster: Allow a RasterSource to specify its color space

The pictures recorded by GraphicsLayers in Blink have a particular
implied color space in the recorded content. This is the color space
that the decoded images are in (and soon to be the color space that
CSS colors are converted into from sRGB).

We need to communicate that information from Blink to cc, so that
the resulting cc::Resources can be tagged with the appropriate color
space.

Of note is that "true color mode" content (content that does linear
blending) has the luxury of being able to decide the target color
space at raster time -- it does not have an implied color space.

BUG=667411
==========

to

==========
Raster: Allow a RasterSource to specify its color space

The pictures recorded by GraphicsLayers in Blink have a particular
implied color space in the recorded content. This is the color space
that the decoded images are in (and soon to be the color space that
CSS colors are converted into from sRGB).

We need to communicate that information from Blink to cc, so that
the resulting cc::Resources can be tagged with the appropriate color
space.

Plumb this through the same channel in WebDisplayItemList that is
used for "IsSuitableForGpuRasterization".

Of note is that "true color mode" content (content that does linear
blending) has the luxury of being able to decide the target color
space at raster time -- it does not have an implied color space.

BUG=667411
==========

[ccameron, 2016-11-23 07:03:25]

PTAL

[ccameron, 2016-11-23 07:39:45]

Description was changed from

==========
Raster: Allow a RasterSource to specify its color space

The pictures recorded by GraphicsLayers in Blink have a particular
implied color space in the recorded content. This is the color space
that the decoded images are in (and soon to be the color space that
CSS colors are converted into from sRGB).

We need to communicate that information from Blink to cc, so that
the resulting cc::Resources can be tagged with the appropriate color
space.

Plumb this through the same channel in WebDisplayItemList that is
used for "IsSuitableForGpuRasterization".

Of note is that "true color mode" content (content that does linear
blending) has the luxury of being able to decide the target color
space at raster time -- it does not have an implied color space.

BUG=667411
==========

to

==========
Raster: Allow a RasterSource to specify its color space

The pictures recorded by GraphicsLayers in Blink have a particular
implied color space in the recorded content. This is the color space
that the decoded images are in (and soon to be the color space that
CSS colors are converted into from sRGB).

We need to communicate that information from Blink to cc, so that
the resulting cc::Resources can be tagged with the appropriate color
space.

Plumb this through the same channel in WebDisplayItemList that is
used for "IsSuitableForGpuRasterization".

Of note is that "true color mode" content (content that does linear
blending) has the luxury of being able to decide the target color
space at raster time -- it does not have an implied color space.

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2016-11-23 07:39:46]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 07:39:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-11-23 19:21:45]

On 2016/11/23 at 07:03:25, ccameron wrote:
> PTAL

WebKit LGTM

[ccameron, 2016-11-23 19:30:10]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2016-11-23 19:30:11]

Thanks!

enne, does the cc/ scheme look reasonable to you (following the path of the GPU
raster hint)?

[ccameron, 2016-11-29 17:39:28]

ping for the cc/ bits

If we end up using Victor's scheme for hijacking display lists, we'll still need
to call this method to inform the renderer that "this should have color
conversion applied manually instead of having Skia do it".

[enne (OOO), 2016-11-29 19:10:12]

lgtm

[ccameron, 2016-11-29 19:43:35]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-11-29 19:43:35]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2525453002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-29 19:44:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 21:15:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 21:15:35]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ccameron, 2016-11-30 02:02:41]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 02:03:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 04:05:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 04:05:12]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[ccameron, 2016-11-30 04:27:00]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-11-30 04:27:00]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2525453002/#ps100001
(title: "Only set implied space when color correct rendering is disabled")

[commit-bot: I haz the power, 2016-11-30 04:27:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 06:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 06:28:32]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[ccameron, 2016-11-30 06:31:02]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-11-30 06:32:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 08:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 08:53:05]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ccameron, 2016-11-30 09:13:06]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-11-30 09:13:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 11:02:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480497186356880,
"parent_rev": "13ef404e110f7035ad5cf0459216b261f1d47197", "commit_rev":
"7503474c284e9ef1df9aebe9c3ffce0960cec940"}

[commit-bot: I haz the power, 2016-11-30 11:03:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-30 11:05:57]

Description was changed from

==========
Raster: Allow a RasterSource to specify its color space

The pictures recorded by GraphicsLayers in Blink have a particular
implied color space in the recorded content. This is the color space
that the decoded images are in (and soon to be the color space that
CSS colors are converted into from sRGB).

We need to communicate that information from Blink to cc, so that
the resulting cc::Resources can be tagged with the appropriate color
space.

Plumb this through the same channel in WebDisplayItemList that is
used for "IsSuitableForGpuRasterization".

Of note is that "true color mode" content (content that does linear
blending) has the luxury of being able to decide the target color
space at raster time -- it does not have an implied color space.

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Raster: Allow a RasterSource to specify its color space

The pictures recorded by GraphicsLayers in Blink have a particular
implied color space in the recorded content. This is the color space
that the decoded images are in (and soon to be the color space that
CSS colors are converted into from sRGB).

We need to communicate that information from Blink to cc, so that
the resulting cc::Resources can be tagged with the appropriate color
space.

Plumb this through the same channel in WebDisplayItemList that is
used for "IsSuitableForGpuRasterization".

Of note is that "true color mode" content (content that does linear
blending) has the luxury of being able to decide the target color
space at raster time -- it does not have an implied color space.

BUG=667411
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/b7210d35c666575a48ed600d7758c451220b09b8
Cr-Commit-Position: refs/heads/master@{#435212}
==========

[commit-bot: I haz the power, 2016-11-30 11:05:59]

Patchset 6 (id:??) landed as
https://crrev.com/b7210d35c666575a48ed600d7758c451220b09b8
Cr-Commit-Position: refs/heads/master@{#435212}