Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Issue 252543002: Removes bad DCHECK in MessagePumpMojo (Closed)

Created:
6 years, 8 months ago by sky
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Removes bad DCHECK in MessagePumpMojo It's entirely possible for the channels to be in other states, such as ready. BUG=none TEST=none R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M mojo/common/message_pump_mojo.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 8 months ago (2014-04-24 17:48:23 UTC) #1
darin (slow to review)
Yeah, of course. That check is racy. LGTM.
6 years, 8 months ago (2014-04-24 17:55:39 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-24 17:57:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/252543002/1
6 years, 8 months ago (2014-04-24 21:54:01 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 02:13:48 UTC) #5
Message was sent while issue was closed.
Change committed as 266080

Powered by Google App Engine
This is Rietveld 408576698