Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2525393002: Use the extensions generated by FeatureInfo in the passthrough cmd decoder. (Closed)

Created:
4 years ago by Geoff Lang
Modified:
4 years ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, Corentin Wallez, Jamie Madill
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the extensions generated by FeatureInfo in the passthrough cmd decoder. BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6c20685647f96ecbc0a1385a3ec9371db58984fb Cr-Commit-Position: refs/heads/master@{#434879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -29 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h View 2 chunks +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc View 3 chunks +2 lines, -23 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
Geoff Lang
PTAL. I think it was a mistake to try to use ANGLE's extension strings. Started ...
4 years ago (2016-11-24 16:27:52 UTC) #7
piman
lgtm
4 years ago (2016-11-28 23:08:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525393002/1
4 years ago (2016-11-29 01:43:59 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 03:54:36 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-29 03:57:14 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c20685647f96ecbc0a1385a3ec9371db58984fb
Cr-Commit-Position: refs/heads/master@{#434879}

Powered by Google App Engine
This is Rietveld 408576698